Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directive for the breadcrumb navigation #107

Merged
merged 3 commits into from
Feb 18, 2016
Merged

Directive for the breadcrumb navigation #107

merged 3 commits into from
Feb 18, 2016

Conversation

mbayopanda
Copy link
Contributor

This PR contains a proposal of a directive for the breadcrumb navigation

@mbayopanda
Directive for the breadcrumb navigation
772b748 
Breadcrumb toolbar directive

Reset changes in enterprise module
@jniles
Copy link
Collaborator

jniles commented Feb 15, 2016

This code looks very good. Some comments:

  1. Could you make the directive an angular.component? It should be an easy change.
  2. Do you need two way data binding (using the '=')? If not, use one-way binding for performance reasons (using the '<' operator).
  3. You should prefix your directives/components with bh so that we can distinguish them from other, external components. This should be called bhBreadcrumb for example.

Your comments are excellent and helpful. Thank you!

@jniles jniles mentioned this pull request Feb 16, 2016
Closed
13 tasks
@jniles
Copy link
Collaborator

jniles commented Feb 17, 2016

These changes are good. Could you update to master? After that, this is able to merged. 👍

@jniles
Copy link
Collaborator

jniles commented Feb 18, 2016

LGTM!

jniles added a commit that referenced this pull request Feb 18, 2016
@jniles
Merge pull request #107 from mbayopanda/directive_breadcrumb
0abaf0b 
Directive for the breadcrumb navigation
@jniles jniles merged commit 0abaf0b into IMA-WorldHealth:master Feb 18, 2016
jniles referenced this pull request in jniles/bhima Jan 9, 2017
@jniles
Merge pull request #107 from sfount/chore-patient-card
5020e5c 
(Chore) Re-factor patient card asthetics
bors bot added a commit that referenced this pull request Feb 25, 2018
@bors
Merge #2570
f9d2afe 
2570: Update bower-npm-resolver to the latest version 🚀 r=jniles a=greenkeeper[bot]


☝️ Greenkeeper’s [updated Terms of Service](https://mailchi.mp/ebfddc9880a9/were-updating-our-terms-of-service) will come into effect on April 6th, 2018.

## Version **0.9.0** of [bower-npm-resolver](https://github.com/mjeanroy/bower-npm-resolver) was just published.

<table>
  <tr>
    <th align=left>
      Dependency
    </td>
    <td>
      bower-npm-resolver
    </td>
  </tr>
  <tr>
    <th align=left>
      Current Version
    </td>
    <td>
      0.8.2
    </td>
  </tr>
  <tr>
    <th align=left>
      Type
    </td>
    <td>
      dependency
    </td>
  </tr>
</table>

The version **0.9.0** is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of bower-npm-resolver.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


---


<details>
<summary>Commits</summary>
<p>The new version differs by 59 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/mjeanroy/bower-npm-resolver/commit/f5ccbdc1972816b796b46394873188c95adc1fe1"><code>f5ccbdc</code></a> <code>release: release version</code></li>
<li><a href="https://urls.greenkeeper.io/mjeanroy/bower-npm-resolver/commit/7e82d965f0ecc53783bd93246c6cc1b394ebb3d8"><code>7e82d96</code></a> <code>chore: add debug message to print package version</code></li>
<li><a href="https://urls.greenkeeper.io/mjeanroy/bower-npm-resolver/commit/cebd6087a6b725556cab8cc03c7a58087a61b459"><code>cebd608</code></a> <code>docs: update license copyright</code></li>
<li><a href="https://urls.greenkeeper.io/mjeanroy/bower-npm-resolver/commit/536943f7adcfd6af93b00f25290eb0232729c6b1"><code>536943f</code></a> <code>chore: pin dependencies versions</code></li>
<li><a href="https://urls.greenkeeper.io/mjeanroy/bower-npm-resolver/commit/a655a5b383eeaf69a85806b632fb1856043e9d29"><code>a655a5b</code></a> <code>Merge pull request #110 from mjeanroy/greenkeeper/pacote-7.4.2</code></li>
<li><a href="https://urls.greenkeeper.io/mjeanroy/bower-npm-resolver/commit/28fbcc276510eb2a4aa2c70c21182d1c688b3977"><code>28fbcc2</code></a> <code>fix(package): update pacote to version 7.4.2</code></li>
<li><a href="https://urls.greenkeeper.io/mjeanroy/bower-npm-resolver/commit/7ad3ebe0eb927e30c8e40ecab345dc968642be80"><code>7ad3ebe</code></a> <code>core: improve error message</code></li>
<li><a href="https://urls.greenkeeper.io/mjeanroy/bower-npm-resolver/commit/7e551152e376dc943fdec7ee344d0993871e3e41"><code>7e55115</code></a> <code>core: update gitignore</code></li>
<li><a href="https://urls.greenkeeper.io/mjeanroy/bower-npm-resolver/commit/6ec96a52129f27499cdd3a4d6e1a8fc589569a30"><code>6ec96a5</code></a> <code>fix: ensure that an npm package is a valid npm package name</code></li>
<li><a href="https://urls.greenkeeper.io/mjeanroy/bower-npm-resolver/commit/8a6061d8e55c45accc681efc3b166deb22d2665d"><code>8a6061d</code></a> <code>Merge pull request #106 from mjeanroy/greenkeeper/cacache-10.0.4</code></li>
<li><a href="https://urls.greenkeeper.io/mjeanroy/bower-npm-resolver/commit/c0562c3fe5f3ca9d7de9edced203b0a64e4fdab6"><code>c0562c3</code></a> <code>Merge pull request #108 from mjeanroy/greenkeeper/eslint-4.18.1</code></li>
<li><a href="https://urls.greenkeeper.io/mjeanroy/bower-npm-resolver/commit/193c313b6ae96cce32671c142b6c32acdda1e479"><code>193c313</code></a> <code>chore(package): update eslint to version 4.18.1</code></li>
<li><a href="https://urls.greenkeeper.io/mjeanroy/bower-npm-resolver/commit/32fc002997125099bb16c47975e94d10665f2f27"><code>32fc002</code></a> <code>Merge pull request #107 from mjeanroy/greenkeeper/gulp-git-2.5.2</code></li>
<li><a href="https://urls.greenkeeper.io/mjeanroy/bower-npm-resolver/commit/dbfb90bc398db958ee71e5c85c9b1f64b45c52e2"><code>dbfb90b</code></a> <code>chore(package): update gulp-git to version 2.5.2</code></li>
<li><a href="https://urls.greenkeeper.io/mjeanroy/bower-npm-resolver/commit/187d89cfbc3e7ef584051d172165a3113911f202"><code>187d89c</code></a> <code>Merge pull request #105 from mjeanroy/greenkeeper/pacote-7.4.0</code></li>
</ul>
<p>There are 59 commits in total.</p>
<p>See the <a href="https://urls.greenkeeper.io/mjeanroy/bower-npm-resolver/compare/177170e0de93745798c3e37bcb4a75ce742d42a9...f5ccbdc1972816b796b46394873188c95adc1fe1">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>


---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbayopanda @jniles