Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(invoices): show the correct error text #990

Conversation

jniles
Copy link
Collaborator

@jniles jniles commented Nov 30, 2016

This commit fixes the error text on the invoice page so that it shows
the correct global error message for missing sales account.

Fixes #989.


Thank you for contributing!

Before submitting this pull request, please verify that you have:

  • Run your code through JSHint. Check out our styleguide.
  • Run integration tests.
  • Run end-to-end tests.
  • Accurately described the changes your are making in this pull request.

For a more detailed checklist, see the official review checklist that this PR will be evaluated against.

Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!

This commit fixes the error text on the invoice page so that it shows
the correct global error message for missing sales account.

Fixes Third-Culture-Software#989.
@jniles jniles added the Bug Fix label Nov 30, 2016
@jniles jniles added this to the Finance Implementation milestone Nov 30, 2016
@sfount sfount merged commit 3696afb into Third-Culture-Software:master Dec 1, 2016
@jniles jniles deleted the fix-invoice-global-error-messages branch December 1, 2016 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(bug) Patient Invoice incorrectly reports that the invoice lines are missing inventory.
2 participants