Process IMAP-Hi Housekeeping data and create CDF file #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tech3371
requested review from
bourque,
sdhoyt,
greglucas,
vmartinez-cu,
laspsandoval and
maxinelasp
and removed request for
a team
tech3371
commented
Mar 25, 2024
| @@ -33,7 +33,7 @@ bitstring = ">=4.0.1" | |||
| cdflib = "==1.2.6" | |||
| imap-data-access = ">=0.5.0" | |||
| python = ">=3.9,<4" | |||
| space_packet_parser = ">=4.1.0" | |||
| space_packet_parser = ">=4.2.0rc3" | |||
There was a problem hiding this comment.
TODO: update this to new version
greglucas
reviewed
Mar 25, 2024
greglucas
approved these changes
Mar 27, 2024
Comment on lines
+42
to
+45
| epoch_converted_time = [ | ||
| calc_start_time(sc_time) for sc_time in metadata_arrays["ccsds_met"] | ||
| ] |
There was a problem hiding this comment.
Not for this PR, but it might be nice if calc_start_time could handle an array and you could instead call:
epoch_converted_times = calc_start_time(metadata_arrays["ccsds_met"])
There was a problem hiding this comment.
I agree. Many of us are doing this. Would be nice to call a common util function for this.
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
This was
linked to
issues
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview