added SWAPI housekeeping processing and CDF attrs #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tech3371
requested review from
bourque,
sdhoyt,
greglucas,
subagonsouth,
vmartinez-cu,
laspsandoval and
maxinelasp
and removed request for
a team
sdhoyt
reviewed
Apr 12, 2024
|
|
||
| for data_packet in packets: | ||
| # Add metadata to array | ||
| for key, value in (data_packet.header | data_packet.data).items(): |
There was a problem hiding this comment.
Is this going to cause the CCSDS header to be put into a data array?
There was a problem hiding this comment.
Yes, I have included header in the CDF so far.
There was a problem hiding this comment.
Is that something SWAPI asked for or is that a standard thing we should do? I wasn't planning to put the headers into the CDFs
There was a problem hiding this comment.
They didn't ask for this. It's something I have to been carrying information over. But I don't think they will complain if I remove it. If you are thinking of using it and if it helps to remove header, then I am happy to.
sdhoyt
approved these changes
Apr 12, 2024
bryan-harter
approved these changes
Apr 15, 2024
tech3371
merged commit 01d260f
into
IMAP-Science-Operations-Center:dev
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
Added SWAPI housekeeping processing and CDF attribute
New Files
Updated Files
Testing