Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparent fog rendering with custom sky boxes #28

Open
MiraculixxT opened this issue Sep 5, 2024 · 1 comment
Open

Transparent fog rendering with custom sky boxes #28

MiraculixxT opened this issue Sep 5, 2024 · 1 comment
Labels
bug Something isn't working compat Mod compatibility

Comments

@MiraculixxT
Copy link

When using a custom sky box texture with any mod (like FabricSkyBoxes), the fog rendering appears transparent to the viewer and world cuts become very visual. This issue only exists if the fog color is not pure white #ffffff.

Current state

Demonstrated with red fog color, appears for all colors.
grafik

Expected result

With custom sky toggled off. Should look like this even with custom sky box textures.
grafik

How to reproduce

  • Use any custom sky box mod to add a sky box texture (example sky: Better Sky)
  • Use a fog color except white
  • Look into distance
@Steveplays28 Steveplays28 added bug Something isn't working compat Mod compatibility labels Sep 6, 2024
@Steveplays28
Copy link
Collaborator

I looked into FabricSkyBoxes' code, it seems like this is an issue on their side.
FabricSkyBoxes [blends]9https://github.com/AMereBagatelle/fabricskyboxes/blob/21d5f9bc358c40ccfced61689b7e1a85364c00e6/common/src/main/java/io/github/amerebagatelle/mods/nuit/mixin/MixinFogRenderer.java#L37) the alpha of the skybox with the fog, causing the transparency (and potential color issues I've seen other people have).

I'll ask about this in their Discord server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compat Mod compatibility
Projects
None yet
Development

No branches or pull requests

2 participants