Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added raster geopackage checker #264

Conversation

ywkim312
Copy link
Member

This PR will check if the geopackage file contains raster layer or no vector date layer.
To test, please use attached geopackage file

Scenario1: Uploading the raster based geopackage file

  1. download attached geopackages.zip file and unzip it. Should be two files, one named guid_test.gpkg, and the other is landcover.gpkg
  2. create a dataset using the following json (the content doesn't matter too much because it is test. Only important one is the format, that should be geopackage)
    {"format": "geopackage", "title": "test-delete", "description": "delete me", "dataType": "incore:addressPoints"}
  3. attached the geopackage file to the dataset using the landcover.gpkg file (raster geopackage)
  4. if you use landocver.gpkg, then you should see the error message saying, it doesn't contain any vector layer or it contains the raster
  5. if you get error in step 3 above, try to attach the guid_test.gpkg (vector data). This should work without any error.
  6. Remove the dataset you created in step 1.
    geopackages.zip

Copy link
Contributor

@ylyangtw ylyangtw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the scenarios. All worked as expected. Changes look good. Approving~

@longshuicy longshuicy merged commit 08a7599 into develop Feb 1, 2024
6 checks passed
@ywkim312 ywkim312 deleted the 258-make-incore-service-to-work-with-raster-based-geopackage-file branch February 1, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make incore service to work with raster based geopackage file
3 participants