Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1주차] 기본/도전/생각 과제 제출 #2

Merged
merged 6 commits into from
Oct 15, 2022
Merged

Conversation

yujindonut
Copy link
Member

@yujindonut yujindonut commented Oct 3, 2022

SERVER PR

  • 기본과제
  • 도전과제
  • 생각과제

🐕 과제 구현 명세

  • interface 폴더 아래 Dinner.ts와 Member.ts라는 파일 생성

image

  • group은 지금까지 같은 조를 했었던 조로 서버분들을 묶었습니다.
  • 하고 싶은 말을 적었습니다.

image

  • [수정] menu라는 배열을 추가해서 밥을 먹게 코드를 작성했습니다.

image

👨‍🦲생각과제👨‍🦲


🐥 이런 점이 새로웠어요 / 어려웠어요

  • 폴더링을 조금 깔끔하게 하고 싶습니다. 다음주에는 조금더 깰꼼한 폴더링으로 돌아오겠습니다
  • 브랜치 파는걸 까먹고 .. 비쥬얼스튜디오에서 그냥 다 메인으로 푸시 했습니다.. ~ 실수 .. 하지 않겠습니다..
  • 함수가 한줄로 표현되는게 진짜 노드의 장점이다. 새롭고 재밌다 서버 최고입니다 ..
  • menu라는 메뉴를 추가하고 타입을 처음에 명시해줬던거랑 달라서 오류가 났었습니다. 타입스크립트는 정말 타입에 예민합니다. 새로워요!

Closes #1

Copy link
Member

@hyesuuou hyesuuou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘보고감미닷 !

Comment on lines 50 to +54
const POME = array.find((pome) => pome.group === '환승연애');
const CORIGOMTANG = array.find((corigomtang) => corigomtang.group === '코리곰탕');
const serverpattzzang = array.find((name) => name.name === '권세훈');
const buddybuddy = array.find((buddy) => buddy.group === '버디버디');
const dinnerMember = array.map((member) => member.name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오왕 find와 map을 기깔나게 쓰셧군요 !!!!

Comment on lines 56 to 59
console.log(`제 코리곰탕 조는요! ${CORIGOMTANG?.name}입니다. 잘부탁드립니다...~!`);
console.log(`환승연애 .. 점 그리워 ~.. : ${POME?.name}`);
console.log(`서버파트장 화이팅 ㅋ ㅋ ! ${serverpattzzang?.name}`);
console.log(`버디버디 조 화이팅이다 ~!~ 아자잣!@!@! ${buddybuddy?.name}`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

..과제가 이렇게 귀여우면 어쩌죠


console.log(`제 코리곰탕 조는요! ${CORIGOMTANG?.name}입니다. 잘부탁드립니다...~!`);
console.log(`환승연애 .. 점 그리워 ~.. : ${POME?.name}`);
console.log(`서버파트장 화이팅 ㅋ ㅋ ! ${serverpattzzang?.name}`);
console.log(`버디버디 조 화이팅이다 ~!~ 아자잣!@!@! ${buddybuddy?.name}`);
console.log(`${dinnerMember[0]}과 ${dinnerMember[1]}은 ${this.menu[0]}와 ${this.menu[1]}을 드세요.`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

메뉴를 두개나 추천해주시다니 , , 마음이 넓으시네여

@@ -2,6 +2,7 @@ import Member from "./Member";

export default interface Dinner {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오왕 default는 모죠 간지나는데 일단 . .

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ES2015가 도입되면서 자바스크립트도 자체 모듈 시스템 문법이 생겨서, require와 module.exports가 import, export default로 바뀌었다고 합니다!! 저도 더 ,,, 공부해온다음에 ,, 더 자세히 얘기 ,,, 써놓을게요 !!

Copy link

@wlwpfh wlwpfh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이번 과제 생각과제까지 하느라 수고하셨습니다 ~

@@ -2,6 +2,7 @@ import Member from "./Member";

export default interface Dinner {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 이 부분이 궁금합니다!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2 (comment) 작성했는데 .. 더 작성 해볼게여~!~!...

@@ -2,6 +2,7 @@ import Member from "./Member";

export default interface Dinner {
members: Member[];
shuffle: (array: Member[]) => Member[];
menu: string[];
shuffle: (array: any[]) => any[];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 이렇게 해서 메뉴도 할 수 있도록 했군요..! 알아가요 ~

@@ -44,16 +45,19 @@ const dinner: Dinner = {
},
organize(array) {
this.shuffle(array);
this.shuffle(this.menu);

const POME = array.find((pome) => pome.group === '환승연애');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find함수까지.. 대단해요..!!!

@unanchoi
Copy link

unanchoi commented Oct 7, 2022

생각과제까지... 너무 고생하셨습니다!!

@yujindonut yujindonut merged commit 6cb6909 into main Oct 15, 2022
@yujindonut yujindonut deleted the 1st-seminar branch October 15, 2022 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 서버 1차 과제
4 participants