-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add oaklib #586
Add oaklib #586
Conversation
When installing Debian packages, the DEBIAN_FRONTEND=noninteractive variable should be passed to `apt-get install`, not `apt-get update`, as it is the `install` command that needs to know it should not try to be interactive.
Add the Ontology Access Kit (oaklib) to the ODKfull image. This implies installing the Javascript lib obographviz, which itself requires Node.js and NPM as well as GraphViz (providing the `dot` command).
The newly added oaklib package needs more recent versions of some Python packages than the onees we had (especially for sssom).
This is very very amazing.. Thanks for doing this! Let's wait for @cmungall to review |
I just moved ogv from my org to this org - does this affect the PR? |
We install Obographviz through NPM. I'm not very familiar with the Node/NPM ecosystem but I think as long as the name of the published package doesn't change, the organisation to which the source repository belongs to shouldn't matter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a docker image in this branch as:
docker build .
and entered as
docker run --network host -it 079d3e44c526 /bin/bash
Inside the image, the lib oaklib
and the runoak
command do not seem exposed:
root@moiraine:/tools# runoak
bash: runoak: command not found
In [1]: import oaklib
---------------------------------------------------------------------------
ModuleNotFoundError Traceback (most recent call last)
<ipython-input-1-a904ee677e33> in <module>
----> 1 import oaklib
ModuleNotFoundError: No module named 'oaklib'
Is there something wrong with this test/invocation?
That’s not how the ODK should be built. By trying to build it by calling Build the ODK by running
in the top-level directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gouttegd Ah, cheers--I was looking in the main README, not the dev one.
Retrying my testing, it all looks good to me now.
Thanks for the testing @kltm! Merging now, |
This PR adds the Ontology Access Kit to the
odkfull
image.This brings in a whole new set of dependencies:
runoak viz
command;obographviz
as it is a Javascript library and script;obographviz
and its Javascript dependencies;dot
command needed byobographviz
.closes #584