Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update constraints.txt #664

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Update constraints.txt #664

merged 1 commit into from
Aug 22, 2022

Conversation

github-actions[bot]
Copy link
Contributor

This pull request updates constraints.txt. Make sure you run make tests manually.

@matentzn
Copy link
Contributor

@gouttegd We do you think of this: https://github.com/INCATools/ontology-development-kit/blob/master/.github/workflows/constraints.yml

Seems to work? I guess it would work even better on the bleeding edge release?

@gouttegd
Copy link
Contributor

Frankly I don’t see the point of updating the constraints every week. It would be completely enough to do it once in a release cycle.

If you do want to do it automatically, then 1) yes it should be based on the :dev image, 2) doing it once every 2 or 3 months should be completely enough, given our current release schedule.

@matentzn
Copy link
Contributor

I keep doing it manually all the time. Here are my reasons:

  1. I need up to date sssom and oak dependencies in ODK all the time.
  2. I would like to update constraints sooner rather than just before release, so that at least all Nico-managed pipelines are tested, and I can be sure that the combination of python tools still work together
  3. This is a nice way to tell me which new dependencies exist - it will also prompt me to think about stuff like "a, finally the new feature X should be available" or "new linkml? need to probably update my code".

Put this way, does it make sense?

@gouttegd
Copy link
Contributor

gouttegd commented Aug 22, 2022

As long as you volunteer to test the new constraints every week, your call. :D

@gouttegd gouttegd closed this Aug 22, 2022
@gouttegd gouttegd reopened this Aug 22, 2022
@gouttegd
Copy link
Contributor

(Sorry, wrong click, didn’t mean to close.)

@matentzn matentzn merged commit f267f94 into master Aug 22, 2022
@matentzn matentzn deleted the create-pull-request/patch branch August 22, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants