Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder integration #20

Merged
merged 26 commits into from
Dec 8, 2021
Merged

Builder integration #20

merged 26 commits into from
Dec 8, 2021

Conversation

ackurth
Copy link
Collaborator

@ackurth ackurth commented Nov 19, 2021

Kaveh and I finished the Builder integration.

The machine parameters at compile time (i.e. number of cores to compile on) are hardcoded in the helper.yaml.
We chose this, since otherwise the users would need to configure one additional config file leading to an unnecessary increase of complexity.
If you, however, would prefer to store them externally, this is also possible.

@jasperalbers
Copy link
Collaborator

I get the following error when trying to execute the current version:

name="sub_bench_job" not found inside "helpers/helpers.yaml"

I myself produced a similar issue when trying to define multiple substitutesets as is currently done in helpers.yaml. I believe one is only allowed to define one (?).

@ackurth
Copy link
Collaborator Author

ackurth commented Nov 22, 2021

Kaveh and I looked into this. We suspect it to be a bug in JUBE. Kaveh will check this tomorrow with the JUBE devlopers. If it turns out to be true, we already have a solution - at the expense of adding one additional helper file - at hand.
If possible, we, however, would try to avoid introducing this new file.

@ackurth
Copy link
Collaborator Author

ackurth commented Nov 25, 2021

@jasperalbers, we resolved the problem.
In order to minimize the user interaction upon running jube run /path/to/benchmark.yaml we introduced a --get --silent mode in Builder.
The code for this modification can be found here. Since this changes is not too large, I think it can be merged into the Builder master rather timely.

@jasperalbers
Copy link
Collaborator

I am getting the following error:

Cannot evaluate "$vps_per_node*$num_nodes" for parameter "num_vps": invalid syntax (<string>, line 1)

If I comment out the build step the bench step works, so it is a problem in the newly introduced build step.
Have you run this on JURECA-DC before?

@Kaveh01
Copy link
Collaborator

Kaveh01 commented Nov 25, 2021

I am getting the following error:

Cannot evaluate "$vps_per_node*$num_nodes" for parameter "num_vps": invalid syntax (<string>, line 1)

If I comment out the build step the bench step works, so it is a problem in the newly introduced build step. Have you run this on JURECA-DC before?

For which benchmark?

@jasperalbers
Copy link
Collaborator

jasperalbers commented Nov 25, 2021

hpc-benchmark 31

@Kaveh01
Copy link
Collaborator

Kaveh01 commented Nov 26, 2021

hpc-benchmark 31

Please give it a try.

@terhorstd terhorstd changed the title Builder Builder integration Nov 30, 2021
@Kaveh01 Kaveh01 force-pushed the builder branch 2 times, most recently from c27b421 to 27b127a Compare December 2, 2021 22:36
…a config file.

Co-authored-by: ackurth <anno.kurth@posteo.de>
@jasperalbers jasperalbers self-assigned this Dec 8, 2021
@jasperalbers
Copy link
Collaborator

Very elegant integration of the build step. All my test run successfully now, thanks a lot @ackurth @Kaveh01 @terhorstd! 🎉

@jasperalbers jasperalbers merged commit f61b2be into main Dec 8, 2021
@jasperalbers jasperalbers deleted the builder branch December 8, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants