Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Largo code over exactly #2

Closed
4 of 6 tasks
benlk opened this issue Jul 9, 2018 · 2 comments
Closed
4 of 6 tasks

Port Largo code over exactly #2

benlk opened this issue Jul 9, 2018 · 2 comments
Milestone

Comments

@benlk
Copy link
Contributor

benlk commented Jul 9, 2018

  • As part of this, open a pull request in Largo that contains the version of Largo with Disclaimers removed.
    • disclaimer_enabled is the option to search for
  • don't port the option-page option to enable/disable it, because that is now controlled by installing/uninstalling the plugin.
  • do port the option-page option to set the sitewide setting

Changes to make in Largo

@benlk benlk added this to the 0.1.0 milestone Jul 9, 2018
@benlk benlk mentioned this issue Jul 10, 2018
1 task
@benlk
Copy link
Contributor Author

benlk commented Jul 10, 2018

Note that https://github.com/INN/largo/blob/v0.5.5.4/tests/inc/widgets/test-disclaimer-widget.php is not ported, as it solely exists to make sure that the Largo option for toggling the disclaimer widget's functionality actually toggles that functionality. In this plugin, the functionality-toggling functionality is toggled by activating or deactivating the plugin.

@benlk
Copy link
Contributor Author

benlk commented Jul 10, 2018

The corresponding Largo pull request is WPBuddy/largo#1501.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant