Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't output a hero image on term archives if the found term meta post ID is null #1838

Closed
benlk opened this issue Dec 16, 2019 · 1 comment
Closed

Don't output a hero image on term archives if the found term meta post ID is null #1838

benlk opened this issue Dec 16, 2019 · 1 comment
Assignees
@joshdarby
Labels
Estimate: < 2 Hours type: bug
Milestone
0.7 - Foundation ...

Comments

@benlk
Copy link
Collaborator

benlk commented Dec 16, 2019

https://github.com/INN/largo/blob/f50df16e9e06fb9402802e2f1ce76ce058d26d76/archive.php#L78-L79

Should be something like

$post_id = largo_get_term_meta_post( $queried_object->taxonomy, $queried_object->term_id ); 
if ( ! empty( $post_id ) ) {
    largo_hero( $post );
}

Reported in INN/umbrella-citylimits#135 (comment)
@benlk benlk mentioned this issue Dec 16, 2019
Merged
1 task
@joshdarby joshdarby self-assigned this Jun 13, 2021
@joshdarby
Copy link
Collaborator

This was fixed in 798d0c5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshdarby joshdarby

Labels
Estimate: < 2 Hours type: bug
Projects
None yet
Milestone
0.7 - Foundation for Customization
Development

No branches or pull requests
2 participants
@benlk @joshdarby