-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Travis CI config, fix broken tests, update README, and diverse minor fixes #1503
Conversation
Failed tests:
|
largo_fb_user_is_followable used the Facebook Follow Button, https://developers.facebook.com/docs/archive/docs/plugins/follow-button/ in order to determine whether a user or page was followable. By using this public button's HTML markup, we were able to make the followability check without using the Facebook Graph API. Facebook deprecated that button on February 5, 2018. To query the Graph API, we need to have an API key. To require Largo users to acquire an API key, for the sole purpose of checking whether their Facebook page is followable, seems excessive. Therefore, since there's no reasonable way to check whether a Facebook profile is followable, deprecate the functionality by making the function always return false, and clean out its tests. If WP_DEBUG or LARGO_DEBUG are set, provide a deprecation notice to the error log.
The Facebook Followable issue is because Facebook deprecated the Follow button on Feb 5, 2018: https://developers.facebook.com/docs/archive/docs/plugins/follow-button/ So I've added a commit that deprecates |
…img tag, as it's not necessary for this function and appears to be the cause of #1404
So the change in 75aad91 successfully removes the image, but doesn't get an opening paragraph tag. The relevant There are a few simple fixes here.
|
For #1503 (comment) This change: - removes an empty <p></p> - removes an empty <p class="whatever"></p> - removes the image but not the p if it's a <p><img/>foo</p> - checks that the foo is left behind - checks that a non-matching image isn't removed
…urrent post does not have featured media thumbnail
Well ... that's an error. But it's not an error I'm worried about. |
We're down to this in PHP 7.1:
|
whoa it worked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me.
Changes
.travis.yml
to read the list of PHP versions we test against.largo_post_social_links()
to make sure that the array keys it's trying to access exist before accessing them.of_sanitize_multicheck()
to initialize a variable accessed as an array with an array instead of an empty string.src=""
attribute, as it's not neededWhy
Two-part: