Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy the fix for "WP_Admin_Bar::add_node was called incorrectly" into 0.5-dev #1504

Merged
merged 1 commit into from
Jul 31, 2018

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Jul 31, 2018

Changes

This closes #1349 in the 0.5 branch. It fixes a spacing error.

Why

Because seeing this in the console log for every single page load makes debugging annoying:

2018/07/31 11:18:49 [error] 33695#0: *39 FastCGI sent in stderr: "PHP message: PHP Notice: WP_Admin_Bar::add_node was called incorrectly. The menu ID should not be empty. Please see Debugging in WordPress for more information. (This message was added in version 3.3.0.) in /Users/blk/sites/largo/wp-includes/functions.php on line 4161" while reading upstream, client: 127.0.0.1, server: , request: "GET / HTTP/1.1", upstream: "fastcgi://unix:/Users/blk/.valet/valet.sock:", host: "largo.test"

And because RC's commit 6e8587a wasn't in the present Largo.

@benlk benlk added type: bug priority: low Nice-to-have in a release. labels Jul 31, 2018
@benlk benlk self-assigned this Jul 31, 2018
@benlk benlk merged commit 6212738 into 0.5-dev Jul 31, 2018
@benlk benlk deleted the 1349-in-0.5 branch July 31, 2018 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Nice-to-have in a release. type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible Largo bug with WP_Admin_Bar::add_node?
2 participants