Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1492 continued: Bylines, Largo Recent Posts Widget, partials/widget-content.php #1607

Merged
merged 4 commits into from
Dec 18, 2018

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Dec 18, 2018

Changes

For #1492's ongoing hunt for undefined variables:

  • further cleanup of partials/widget-content.php
  • further cleanup of the Largo Recent Posts widget

To fix an uninitialized variable caused by the corner case where Co-Authors Plus is active, and a post has an author term, but the term has no corresponding guest-author post (Automattic/Co-Authors-Plus#637):

  • catch the uninitialized variable, output an HTML comment in the byline complaining that the post has no author term. If WP_DEBUG or LARGO_DEBUG are true, send that message to the error log.

@benlk benlk added type: bug priority: normal Must be completed before release of this version of plugin. labels Dec 18, 2018
@benlk benlk added this to the 0.6.2 milestone Dec 18, 2018
@benlk benlk merged commit 95b5788 into 0.5-dev Dec 18, 2018
benlk added a commit to INN/umbrella-publicsource that referenced this pull request Dec 18, 2018
benlk added a commit to INN/umbrella-publicsource that referenced this pull request Dec 18, 2018
@benlk benlk deleted the 1492-benlk-dec-18 branch July 18, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: normal Must be completed before release of this version of plugin. type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant