Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use empty() check in conditional in largo_maybe_top_term #1613

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Use empty() check in conditional in largo_maybe_top_term #1613

merged 1 commit into from
Apr 19, 2019

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Jan 9, 2019

Changes

  • Uses an empty( $top_term ) check, rather than using the bare value of $top_term

Why

Because doing so improves code quality.

@benlk benlk added the priority: normal Must be completed before release of this version of plugin. label Jan 9, 2019
@benlk benlk added this to the 0.6.2 milestone Jan 9, 2019
@benlk
Copy link
Collaborator Author

benlk commented Mar 15, 2019

  • needs changelog

@benlk
Copy link
Collaborator Author

benlk commented Apr 19, 2019

eh; this can fall under "more bug fixes and quality improvements"

@benlk benlk merged commit 37e7b9d into 0.5-dev Apr 19, 2019
@benlk benlk deleted the benlk-largo_maybe_top_term-if-empty branch July 18, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
priority: normal Must be completed before release of this version of plugin. status: needs review
Projects
None yet
Milestone
0.6.2
Development

Successfully merging this pull request may close these issues.
2 participants
@benlk @tylermachado