Adding HTML comment in markup when registering sidebars

[seanchayes]

#1482
I've added the id to the register_sidebar to be output as an html comment in part of the before_widget markup.

The other option would be to do the same but as a class.

@benlk
@INN/tech-team

[benlk]

This is an interesting way of doing it; thank you! Can you provide some output code from this on pages, perhaps a diff of a homepage or category page with sidebars, diffing current 0.5-dev with this PR? If not, we'll get around to doing that diff ourselves later.

[seanchayes]

I've captured these screenshots of the the markup when using this branch of code for the home page, a category/archive page and an article page.

I have added diff files too after each one.

Article page

article-diff.txt

Category / archive page

archive-diff.txt

Homepage

homepage-diff.txt

As an option, if desired, I could add a closing html comment in the sidebar code too. So we have <!-- Sidebar name --> in the before_widget. I could add <!-- / Sidebar name --> to the after_widget

Regardless let me know if you have any questions.

[benlk]

This is approved for merge; @seanchayes how would you like to be credited in the changelog, release notes, and readme lists of contributors?

[seanchayes]

Yes - thank you.

[benlk]

What name should we call you by in those places?

[seanchayes]

Just like most of the other: seanchayes with link to Github profile https://github.com/seanchayes/ please. Thank you

…

On Fri, Apr 12, 2019 at 5:48 PM Ben Keith ***@***.***> wrote: What name should we call you by in those places? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1632 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA8_eNiozGxOkV6Phw3wFUV4QpB9ljHEks5vgQ1IgaJpZM4axpsr> .