Make sure the gallery doesn't have a navis-before
child on open
#1743
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If it does have that child, the bad settings won't be applied.
Changes
This pull request makes the following changes:
.navis-before
child before firing functions to modify styles and add the X button.Why
For #1700
Testing/Questions
Features that this PR affects:
Questions that need to be answered before merging:
Steps to test this PR:
Given a single image in an image block that is aligned left or right, take the following steps to reproduce this bug:
addCloseX
is called again, adding a duplicateX
in the modal (which is invisible to the user because it's stacked atop the current X, using the same CSS rules for positioning)closeSingle
https://github.com/INN/largo/blob/e2ac830239452658c285860b330d521c6a0f300e/lib/navis-slideshows/js/navis-slideshows.js#L274-L276closeSingle
when the image is closed: https://github.com/INN/largo/blob/e2ac830239452658c285860b330d521c6a0f300e/lib/navis-slideshows/js/navis-slideshows.js#L177