JarLauncher always use the same tmp directory

[lucacampanellaadn]

The JarLauncher in the spoon decompiler always uses the same tmp directory, no matter if the jar changes. This result in having classes inside the model that were not actually inside the jar, just because the decompiled source code is still there from the previous Jar.

The line that gives the problem is line 92 in JarLauncher.java:
decompiledSrcPath = System.getProperty("java.io.tmpdir") + System.getProperty("file.separator") + "spoon-tmp";

I suggest to create a new random directory every time and delete it at the end, or just delete this one every time.
Thanks

[nharrand]

It should already be deleted. (which means that if it isn't its a bug indeed!)

by lines 96-100

if (decompiledRoot.exists() && !decompiledRoot.canWrite()) {
	throw new SpoonException("Dir " + decompiledRoot.getPath() + " already exists and is not deletable.");
} else if (decompiledRoot.exists() && decompile) {
	decompiledRoot.delete();
}

Do you get a SpoonException? What permission does your temporary directory has?

[lucacampanellaadn]

Hi! Thanks for the reply. Looking at the javadoc it says:
If this pathname denotes a directory, then the directory must be empty in order to be deleted.
I guess this is the problem, being the directory full with decompiled sources.
Thanks
Luca

[nharrand]

Ok my bad then. I'll fix this ASAP.