-
-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query improvements - CtQuery and CtBaseQuery #1076
Conversation
- Extraction of code to CtBaseQuery to make code cleaner and to allow reuse of queries - CtFunction can return Iterator now too
@monperrus , I suggest this way to understand each other and to discuss future steps
Conceptual model
Mapping of Concepts to java classesI suggest to postpone the discussion of the content of this table after we have agreed the Conceptual model and we converge on the names for these concepts. The table below is there just to make definition of concepts more exact in case of some ambiguity... you can have a look into java code of this PR.
|
Change CtConsumable#accept ... CtConsumer<R> to CtConsumer<Object>
public interface CtQuery extends CtQueryable.Step<CtQuery> {
CtQuery setInput(Object... input); How to fix it? |
Was decided to continue with #1090. Closing this one |
This PR is a proposed solution for the #1070.
It actually does not 100% fits to solution suggested by Martin. I suggest to have a look at this to make further discussion less abstract. So we can now discuss exact code lines and avoid other misunderstandings.