fix of ElasticSearch access path problem #1099

[pvojtechovsky]

Here is the test which can be used to reproduce the problem in #1099

I will check how to fix it today or tomorrow

[pvojtechovsky]

There was problem with detection of visibility of nested private classes. Now it correctly decides that all private classes in scope of one top level class can access each other.
This fix slightly changes behavior of some other tests, therefore I updated these existing tests too, so they are passing now.

[surli]

Ok I think there's a behaviour change here, but maybe it's better, I'll try to clarify it.
What we had before was:

abstract class AbstractMapBasedMultimap<K, V> {
    private class WrappedCollection {
        class WrappedIterator {        }
    }

    private class WrappedList extends AbstractMapBasedMultimap<K, V>.WrappedCollection {
        private class WrappedListIterator extends AbstractMapBasedMultimap<K, V>.WrappedList.WrappedIterator {        }
    }
}

What we have now is:

abstract class AbstractMapBasedMultimap<K, V> {
    private class WrappedCollection {
        class WrappedIterator {        }
    }

    private class WrappedList extends AbstractMapBasedMultimap<K, V>.WrappedCollection {
        private class WrappedListIterator extends AbstractMapBasedMultimap<K, V>.WrappedCollection.WrappedIterator {        }
    }
}

which means if now you redefine class WrappedIterator in WrappedList it won't be take into account.
But the original source code is:

abstract class AbstractMapBasedMultimap<K, V> {
	private class WrappedCollection {
		class WrappedIterator {
		}
	}
	private class WrappedList extends WrappedCollection {
		private class WrappedListIterator extends WrappedIterator {
		}
	}
}

And I don't think the WrappedIterator here point to WrappedList.WrappedIterator... WDYT @tdurieux ?

[tdurieux]

It is hard to say what is the best solution.
I cannot find any behavior change.

[pvojtechovsky]

which means if now you redefine class WrappedIterator in WrappedList it won't be take into account.

We can make a test for that. As long as there is no ambiguous name, the algorithm can use arbitrary access path. But once there are two WrappedIterator instances in different scope, then we will see whether it behaves correctly

[surli]

It could be great to add the test: we check with @tdurieux and it will work as defined in the test. However if you build the model and then you put dynamically a new class WrappedIterator in WrappedList the WrappedListIterator continue to extend the old WrappedIterator and not the newly one.
There is a real discussion here on what should be the behaviour, but I think it's out of the scope of this PR.