Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: early terminating query #1138

Merged
merged 5 commits into from
Jan 21, 2017

Conversation

pvojtechovsky
Copy link
Collaborator

Solution for #1120

@monperrus
Copy link
Collaborator

it looks good, thanks.

do we need a public interface for CtQueryContext? Would a private class be OK instead?

@pvojtechovsky
Copy link
Collaborator Author

public interface for CtQueryContext? Would a private class be OK instead?

I agree, that for now it can be private. Later I have some plans with it, but it is not mature enough, so it is better to hide it.
I will do it.

@pvojtechovsky
Copy link
Collaborator Author

Looks like this is done from my point of view

@monperrus monperrus merged commit 7694957 into INRIA:master Jan 21, 2017
@monperrus
Copy link
Collaborator

thanks a lot for this series of PRs.

@pvojtechovsky pvojtechovsky deleted the earlyTerminatingQuery branch January 21, 2017 11:52
@pvojtechovsky
Copy link
Collaborator Author

Thanks a lot for managing this nice project and for Your time spent on reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants