Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Consumer#andThen isDefaultMethod() #1165

Merged
merged 1 commit into from
Feb 5, 2017
Merged

fix: Consumer#andThen isDefaultMethod() #1165

merged 1 commit into from
Feb 5, 2017

Conversation

pvojtechovsky
Copy link
Collaborator

This PR contains failing test, which reproduces issue #1163

@pvojtechovsky pvojtechovsky changed the title test: Consumer#andThen isDefaultMethod() fix: Consumer#andThen isDefaultMethod() Feb 2, 2017
@pvojtechovsky
Copy link
Collaborator Author

The java.lang.reflect.Method#isDefault is not known by java 7 runtime. How do you compile java 8 features?

@pvojtechovsky
Copy link
Collaborator Author

The java 8 Method#isDefault() is called by java reflection now. So it will work on both Java 7 and 8.
This PR is done from my point of view.

This was referenced Feb 3, 2017
Closed
Merged
@surli surli merged commit 870a297 into INRIA:master Feb 5, 2017
@pvojtechovsky pvojtechovsky deleted the Consumer#andThen_isNotDefault branch February 5, 2017 12:56
@surli surli mentioned this pull request Feb 6, 2017
Closed
@tdurieux tdurieux mentioned this pull request Mar 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pvojtechovsky @surli