-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
review: fix: some positions bugs #1493
Conversation
Looks good for me. Thanks @pvojtechovsky |
|
||
return cf.createSourcePosition(cu, sourceStart, sourceEnd, lineSeparatorPositions); | ||
/** | ||
* @return index of first whitespace char, searching backward. Can return off if it is whitespace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong doc: must be "forward" for this one.
|
||
/** | ||
* @return index of first non whitespace char, searching backward. Can return off if it is non whitespace. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here: must be forward in doc.
Thanks for pointing to that. I fixed that. |
No description provided.