Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated mvn eclipse:eclipse in README #2903

Merged
merged 1 commit into from
Mar 9, 2019
Merged

Remove deprecated mvn eclipse:eclipse in README #2903

merged 1 commit into from
Mar 9, 2019

Conversation

mickaelistria
Copy link
Contributor

mvn eclipse:eclipse has been deprecated for many years now. Importing a Maven project in Eclipse IDE is usually better done by the File > Import > Maven > Existing Maven project... wizard.

`mvn eclipse:eclipse` has been deprecated for many years now. Importing a Maven project in Eclipse IDE is usually better done by the File > Import > Maven > Existing Maven project... wizard.
@surli
Copy link
Collaborator

surli commented Mar 8, 2019

Do you know if https://github.com/INRIA/spoon/blob/master/spoon-pom/pom.xml#L240 is related to it? If so it should be removed too I guess.

@mickaelistria
Copy link
Contributor Author

Nope it's not related.
This block mentions the Eclipse IDE that the "copy-dependencies" step should be ignored. There can be several reasons for that: 1. The copy-depenendencies goal isn't "incremental" so it cannot be performed during Eclipse IDE build, or 2. The copy-dependencies goal isn't working well in the Eclipse IDE and is better kept out, or 3. The copy-dependencies goal is useless when inside the IDE and is better being skipped to save time, or maybe others. Depending on the reason, there are several possible actions. In an ideal work, the copy-depedencies goal can works fine under Eclipse IDE (ie conforms to recommendation in https://www.eclipse.org/m2e/documentation/m2e-making-maven-plugins-compat.html), in which case you can remove this block and you'd get good outcome in the Eclipse IDE. For other cases, it could be worth trying to improve Maven itself to have the mojo enabling https://www.eclipse.org/m2e/documentation/m2e-making-maven-plugins-compat.html (it's not that hard), or to sort out which issue causes this plugin to be disabled for m2e and report (and even fix) them where most appropriate.

@monperrus monperrus merged commit d8bd8e4 into INRIA:master Mar 9, 2019
@monperrus
Copy link
Collaborator

Thanks @mickaelistria and welcome to Spoon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants