Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix nested class field read problem #3335

Merged
merged 4 commits into from
Apr 20, 2020

Conversation

slarse
Copy link
Collaborator

@slarse slarse commented Apr 18, 2020

Fix #3334

Hi!

This is a suggested fix for #3334. To the best of my knowledge, this does the same thing that @Egor18 implemented with #3331, but using the JDT tree instead.

Please see #3334 for a detailed description of the problem. I'm also running some tests locally with Spork to see if this solves the problems I encountered, will check back once those have completed.

@slarse slarse changed the title review: fix: Fix nested class field read problem WIP: fix: Fix nested class field read problem Apr 18, 2020
@slarse
Copy link
Collaborator Author

slarse commented Apr 18, 2020

This fix caused further issues for me. Will keep debugging. It may be a problem on my end and not in this fix itself.

@slarse
Copy link
Collaborator Author

slarse commented Apr 19, 2020

After a lot of testing, I've found that the further issues I encountered were caused by Spoon incorrectly marking some package references as implicit (that are in fact explicit), and vice versa. I'm currently trying to figure out whether the two problems are related or not.

EDIT: Seem unrelated, see this issue: #3336

@slarse slarse changed the title WIP: fix: Fix nested class field read problem review: fix: Fix nested class field read problem Apr 19, 2020
@monperrus monperrus changed the title review: fix: Fix nested class field read problem fix: fix nested class field read problem Apr 20, 2020
@monperrus monperrus merged commit f3d1677 into INRIA:master Apr 20, 2020
@monperrus
Copy link
Collaborator

Thanks a lot, merging this one which is atomic, CI green and LGTM.

#3331 introduced a major regression see https://ci.inria.fr/sos/

Let's how this better fix improve the situation.

@monperrus
Copy link
Collaborator

@slarse your fix was effective, all the broken full-project transfos are back to green: https://ci.inria.fr/sos/

thanks again.

@slarse
Copy link
Collaborator Author

slarse commented Apr 21, 2020

@monperrus Awesome, glad I could help!

@slarse slarse deleted the issue/3334-fix-nested-field-read branch May 28, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants