-
-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix nested class field read problem #3335
fix: fix nested class field read problem #3335
Conversation
This fix caused further issues for me. Will keep debugging. It may be a problem on my end and not in this fix itself. |
After a lot of testing, I've found that the further issues I encountered were caused by Spoon incorrectly marking some package references as implicit (that are in fact explicit), and vice versa. I'm currently trying to figure out whether the two problems are related or not. EDIT: Seem unrelated, see this issue: #3336 |
Thanks a lot, merging this one which is atomic, CI green and LGTM. #3331 introduced a major regression see https://ci.inria.fr/sos/ Let's how this better fix improve the situation. |
@slarse your fix was effective, all the broken full-project transfos are back to green: https://ci.inria.fr/sos/ thanks again. |
@monperrus Awesome, glad I could help! |
Fix #3334
Hi!
This is a suggested fix for #3334. To the best of my knowledge, this does the same thing that @Egor18 implemented with #3331, but using the JDT tree instead.
Please see #3334 for a detailed description of the problem. I'm also running some tests locally with Spork to see if this solves the problems I encountered, will check back once those have completed.