Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies regarding CRSs EPSG:5013, EPSG:5014 and EPSG:5015 #669

Closed
heidivanparys opened this issue Dec 2, 2021 · 4 comments
Closed
Labels
deployed in reference validator Solution deployed in production
Milestone

Comments

@heidivanparys
Copy link

There is a discrepancy between the different tests regarding the CRSs with EPSG codes 5013, 5014 and 5015.

In commit inspire-eu-validation/ets-repository@b2f37c0, CRSs with EPSG codes 5013, 5014 and 5015 were added to the ETS for checking data, see also #307. That change was not done in the corresponding abstract test, available at http://inspire.ec.europa.eu/id/ats/data/master/reference-systems/spatial (https://github.com/inspire-eu-validation/data/blob/master/reference-systems/spatial.md).

The CRSs with EPSG codes 5013, 5014 and 5015 are not present either in the tests for metadata, see:

In addition:

  1. Where is the most recent list and authoritative list for the INSPIRE approved CRSs?
  2. What is the procedure for adding CRSs for regions outside continental Europe to that list? (which is allowed already today, before the upcoming amendment, according to https://eur-lex.europa.eu/legal-content/EN/TXT/HTML/?uri=CELEX:02010R1089-20141231#tocId136)
@fabiovin
Copy link
Collaborator

fabiovin commented Dec 6, 2021

Dear @heidivanparys,

thank you for the issue, we will update all the related ATS and ETS with the new EPSG codes already added for data.

@arantzaetxebarria, @dperezBM, could you please check all ATS/ETS which include tests on CRS and update them with EPSG codes (5013, 5014 and 5015) already added for data check? Thanks.

Regarding your questions:

  1. At the moment, there is not an official list and since there are different ATS/ETS that use CRSs, I think the right place would be the INSPIRE registry.
  2. There is no defined procedure for that, the inclusion of the EPSG codes 5013, 5014 and 5015 was discussed and approved in a MIG-T meeting.

@arantzaetxebarria
Copy link
Collaborator

Dear @heidivanparys

We have updated the ETS with the new EPSG codes, on the staging instance. Could you please test again and verify?

Thanks

@arantzaetxebarria arantzaetxebarria added ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing and removed under development labels Jan 3, 2022
@arantzaetxebarria
Copy link
Collaborator

Dear @heidivanparys

As we are going to make a new release in the coming days, we need to confirm that the fix for your issue in the staging environment is right. Could you please verify? Thanks.

Regards

@heidivanparys
Copy link
Author

I tested with https://github.com/INSPIRE-MIF/helpdesk-validator/blob/master/examples/Dataset_metadata_2.0_example.xml, with the following changes:

  <gmd:referenceSystemInfo>
    <gmd:MD_ReferenceSystem>
      <gmd:referenceSystemIdentifier>
        <gmd:RS_Identifier>
          <gmd:code>
            <gmx:Anchor xlink:href="http://www.opengis.net/def/crs/EPSG/0/5013">EPSG:5013</gmx:Anchor>
          </gmd:code>
        </gmd:RS_Identifier>
      </gmd:referenceSystemIdentifier>
    </gmd:MD_ReferenceSystem>
  </gmd:referenceSystemInfo>

→ passes, as expected.

  <gmd:referenceSystemInfo>
    <gmd:MD_ReferenceSystem>
      <gmd:referenceSystemIdentifier>
        <gmd:RS_Identifier>
          <gmd:code>
            <gmx:Anchor xlink:href="http://www.opengis.net/def/crs/EPSG/0/5015">EPSG:5015</gmx:Anchor>
          </gmd:code>
          <gmd:codeSpace>
            <gco:CharacterString>WRONG</gco:CharacterString>
          </gmd:codeSpace>
        </gmd:RS_Identifier>
      </gmd:referenceSystemIdentifier>
    </gmd:MD_ReferenceSystem>
  </gmd:referenceSystemInfo>

→ fails, as expected.

@arantzaetxebarria arantzaetxebarria added solved Solution developed and accepted, not yet deployed and removed ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing labels Jan 18, 2022
@arantzaetxebarria arantzaetxebarria added this to the v2022.0 milestone Jan 18, 2022
@dperezBM dperezBM added deployed in reference validator Solution deployed in production and removed solved Solution developed and accepted, not yet deployed labels Jan 27, 2022
@dperezBM dperezBM closed this as completed Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed in reference validator Solution deployed in production
Projects
None yet
Development

No branches or pull requests

4 participants