Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov upload error #15

Closed
prasadtalasila opened this issue Mar 8, 2023 · 7 comments
Closed

Codecov upload error #15

prasadtalasila opened this issue Mar 8, 2023 · 7 comments
Assignees

Comments

@prasadtalasila
Copy link
Contributor

Codecov reports are not being uploaded correctly.

@Omarley7
Copy link
Contributor

@prasadtalasila I assume this is the missing coverage on codeclimate?

@prasadtalasila
Copy link
Contributor Author

@Omarley7 , both codeclimate and codecov support test coverage reports. Codecov is better for two reasons.

  1. It has less complicated github actions setup
  2. It's presentation of the results.
    When everything is good, this page should show us the test coverage results.

@Omarley7
Copy link
Contributor

Omarley7 commented Mar 23, 2023

@prasadtalasila The upload seems to be working fine. The issue was generation of the coverage report. We have it working on our fork atm (only unittest so far), so should start working after next PR.

@prasadtalasila
Copy link
Contributor Author

prasadtalasila commented Mar 23, 2023

@Omarley7 Let's keep this open until the PR is merged. Did you put in the codecov token in the github environment secrets?

@prasadtalasila
Copy link
Contributor Author

This issue has been solved in PR #20.

@prasadtalasila
Copy link
Contributor Author

The playwright tests are still not uploaded correctly to codecov. This needs fixing.

@prasadtalasila prasadtalasila self-assigned this Apr 20, 2023
@prasadtalasila
Copy link
Contributor Author

issue #45 has more details on the playwright test upload to codecov. No need to have this issue open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants