Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

440 update GitHub actions #445

Merged
merged 4 commits into from
Aug 1, 2024
Merged

440 update GitHub actions #445

merged 4 commits into from
Aug 1, 2024

Conversation

ekraffmiller
Copy link
Contributor

@ekraffmiller ekraffmiller commented Jul 25, 2024

What this PR does / why we need it: Updates Github Action triggers for Chromatic and test builds

Which issue(s) this PR closes:

Closes #440

Special notes for your reviewer:
New triggers for the actions:

  • chromatic and chromatic-design-system: all pull_request events
  • test, lint and accessibility: push events

A push on a PR branch generates both a 'push' event and a pull request 'synchronize' event. So the test actions are not triggered on a push event, only on PR open and re-open. This will reduce the duplicate Github actions that we have been seeing.

For the Chromatic actions, if this change still isn't enough to stop us from hitting the monthly limit, another thing we could think of doing is make the action 'on demand', so it would only be manually triggered when it is necessary for review.

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@coveralls
Copy link

coveralls commented Jul 25, 2024

Coverage Status

coverage: 97.774%. remained the same
when pulling ee2584e on 319-update-github-actions
into 6bc2261 on develop.

@ekraffmiller
Copy link
Contributor Author

Closing this to trigger the PR reopen event

@ekraffmiller
Copy link
Contributor Author

Re-opening to test that github actions will run

@ekraffmiller ekraffmiller reopened this Jul 25, 2024
@ekraffmiller ekraffmiller added tests Add or improve existing tests FY25 Sprint 2 FY25 Sprint 2 GREI Re-arch GREI re-architecture-related labels Jul 25, 2024
@g-saracca g-saracca self-assigned this Jul 30, 2024
Copy link
Contributor

@g-saracca g-saracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@g-saracca g-saracca removed their assignment Jul 31, 2024
Copy link
Contributor

@GPortas GPortas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@GPortas GPortas merged commit 7693608 into develop Aug 1, 2024
16 of 20 checks passed
@GPortas GPortas deleted the 319-update-github-actions branch August 1, 2024 09:45
@ekraffmiller ekraffmiller added the Size: 3 A percentage of a sprint. 2.1 hours. label Sep 20, 2024
@GPortas GPortas added SPA.Q3 Not related to any specific Q3 feature Original size: 3 labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 2 FY25 Sprint 2 GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q3 Not related to any specific Q3 feature tests Add or improve existing tests
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Update Github Actions for Chromatic Snapshot and tests
4 participants