-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
440 update GitHub actions #445
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closing this to trigger the PR reopen event |
Re-opening to test that github actions will run |
ekraffmiller
added
tests
Add or improve existing tests
FY25 Sprint 2
FY25 Sprint 2
GREI Re-arch
GREI re-architecture-related
labels
Jul 25, 2024
g-saracca
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
GPortas
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
FY25 Sprint 2
FY25 Sprint 2
GREI Re-arch
GREI re-architecture-related
Original size: 3
Size: 3
A percentage of a sprint. 2.1 hours.
SPA.Q3
Not related to any specific Q3 feature
tests
Add or improve existing tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Updates Github Action triggers for Chromatic and test builds
Which issue(s) this PR closes:
Closes #440
Special notes for your reviewer:
New triggers for the actions:
A push on a PR branch generates both a 'push' event and a pull request 'synchronize' event. So the test actions are not triggered on a push event, only on PR open and re-open. This will reduce the duplicate Github actions that we have been seeing.
For the Chromatic actions, if this change still isn't enough to stop us from hitting the monthly limit, another thing we could think of doing is make the action 'on demand', so it would only be manually triggered when it is necessary for review.
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: