Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not expose ugly user identifiers when assigning roles #1123

Closed
pdurbin opened this issue Nov 14, 2014 · 8 comments
Closed

Do not expose ugly user identifiers when assigning roles #1123

pdurbin opened this issue Nov 14, 2014 · 8 comments
Assignees
Labels
Type: Bug a defect UX & UI: Design This issue needs input on the design of the UI and from the product owner

Comments

@pdurbin
Copy link
Member

pdurbin commented Nov 14, 2014

This is a follow on to #1080 about how we currently see @ signs when assigning roles and permissions.

For Shibboleth users especially, the user identifier is long and ugly (screenshot below) and should not be shown. For example: @https://idp.testshib.org/idp/shibboleth|myself@testshib.org

root_dataverse_-_2014-11-14_13 58 09

@pdurbin pdurbin added UX & UI: Design This issue needs input on the design of the UI and from the product owner Status: Dev Type: Bug a defect labels Nov 14, 2014
@pdurbin pdurbin added this to the Beta 9 - Dataverse 4.0 milestone Nov 14, 2014
@eaquigley
Copy link
Contributor

@scolapasta we talked about this yesterday right? you had a solution for it, yes?

@scolapasta
Copy link
Contributor

I was waiting until we have the final discussion on user identifiers / names to do this. We had previously said we would show the real name here and you would search for "Gustavo Durand" instead of @gdurand. (that is the solution I spoke of)

I want to make sure what we decide that before using it, or if we go with usernames.

Bu if I have time, I'll try to get this before our review with Merce on Monday, so it looks nice for the discussion.

@pdurbin
Copy link
Member Author

pdurbin commented Nov 14, 2014

We had previously said we would show the real name here and you would search for "Gustavo Durand" instead of @gdurand

This sounds like a fine solution. I opened this ticket because I don't want us to expose the internal user identifiers which can be quite ugly. Showing the name instead (i.e. "Gustavo Durand") sounds great!

@scolapasta
Copy link
Contributor

This is done, but needs discussion. Right now I show name and e-mail (as an example). I could show Affiliation, though that requires a (hopefully minor) back end change.

@pdurbin
Copy link
Member Author

pdurbin commented Nov 17, 2014

Right now I show name and e-mail

We probably shouldn't show email addresses. When the whole world can sign up for an account, anyone could sign up and discover people's email addresses. #749 is about how we a sign up should let people know that display names will be searchable, not email addresses.

In #759 we stopped indexing email addresses for privacy.

@scolapasta
Copy link
Contributor

Yes, that's why I said as an example. We never got to this in the meeting Monday, but it was meant to be a point of discussion.

@scolapasta
Copy link
Contributor

Changed it to name and affiliation for now. So I can pass this to QA (we still can decide what is best, but this way no one is upset with e-mail there).

@scolapasta scolapasta removed their assignment Nov 20, 2014
@kcondon kcondon self-assigned this Nov 20, 2014
@kcondon
Copy link
Contributor

kcondon commented Nov 22, 2014

OK, currently uses name and affilation.
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug a defect UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Development

No branches or pull requests

4 participants