Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computational Workflow metadata block bug: links don't link #10339

Closed
kmika11 opened this issue Feb 22, 2024 · 5 comments · Fixed by #10441
Closed

Computational Workflow metadata block bug: links don't link #10339

kmika11 opened this issue Feb 22, 2024 · 5 comments · Fixed by #10441
Assignees
Labels
GREI 6 Connect Digital Objects Size: 0.5 A percentage of a sprint. 0.35 hours Type: Bug a defect
Milestone

Comments

@kmika11
Copy link
Contributor

kmika11 commented Feb 22, 2024

In the Computational Workflow metadata block, the field for "External Code Repository URL" requires a valid URL, but then does not present a link in the UI.

What steps does it take to reproduce the issue?

  • When does this issue occur?
    When adding a URL to the "External Code Repository URL" field in the Computational Workflow metadata block.

  • Which page(s) does it occurs on?
    The dataset page, under the Metadata tab.

  • What happens?
    Plain text is displayed.

  • To whom does it occur (all users, curators, superusers)?
    All users.

  • What did you expect to happen?
    A clickable link to be displayed that takes the user to the URL location.

Which version of Dataverse are you using?
6.1

Any related open or closed issues to this bug report?
No

Screenshots:
Screenshot 2024-02-22 at 4 45 40 PM

--

Screenshot 2024-02-22 at 4 46 29 PM
@cmbz
Copy link

cmbz commented Feb 23, 2024

Related to: IQSS/dataverse-pm#146

@cmbz cmbz moved this to SPRINT- NEEDS SIZING in IQSS Dataverse Project Mar 18, 2024
@jggautier
Copy link
Contributor

In the metadatablock's TSV (see copy on Google Sheets), the field's "fieldType" is url, so it accepts only that. But its "displayFormat" is empty, where we would normally have something like <a href="#VALUE" target="_blank">#VALUE</a>, so that the URL is displayed as a link.

So I think we'd want to add <a href="#VALUE" target="_blank">#VALUE</a> for its "displayFormat". Then follow the steps for reloading the metadata block.

@pdurbin
Copy link
Member

pdurbin commented Mar 25, 2024

@jggautier yep, sounds right. We'll also want to update the version in git, of course: https://github.com/IQSS/dataverse/blob/develop/scripts/api/data/metadatablocks/computational_workflow.tsv

@jggautier
Copy link
Contributor

Ah, yeah updating that TSV file, not the Google Sheets copy, is what I meant. Once that TSV file is updated, I could update the Google Sheets copy.

@cmbz cmbz added the Size: 0.5 A percentage of a sprint. 0.35 hours label Mar 26, 2024
@cmbz cmbz moved this from SPRINT- NEEDS SIZING to SPRINT READY in IQSS Dataverse Project Mar 26, 2024
@pdurbin pdurbin moved this from SPRINT READY to This Sprint 🏃‍♀️ 🏃 in IQSS Dataverse Project Mar 27, 2024
@jggautier jggautier assigned kmika11 and unassigned jggautier Mar 28, 2024
@pdurbin
Copy link
Member

pdurbin commented Mar 28, 2024

@cmbz FYI, @kmika11 made a pull request...

... so I advanced it to "ready for review" and removed this issue (10339) from the board, like we usually do. It was in "this sprint".

I'm not sure if Katie has permission to do this on her own but we could obviously adjust perms for the future.

Thanks for the pull request, Katie!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GREI 6 Connect Digital Objects Size: 0.5 A percentage of a sprint. 0.35 hours Type: Bug a defect
Projects
None yet
4 participants