Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we are effectively examining single tests, one of the big problems left to solve is how to study the combination of groups of tests by ANDing and ORing their results. In this PR, I draft some functions to help us explore every possible AND/OR combination of a collection of tests.
combineTests
incombineTests.py
is the top-level function for doing this. It takes as an argument a list of lists, where the first index counts tests and the second counts profiles, since this is exactly what we are currently generating around line 206 inAutoQC.py
. It uses the other functions incombineTests.py
to enumerate every possible way to combine every possible subset of tests, and returns a list of lists that describe each combination and the resulting assessment of each profile.There is a dummy execution of this function in
combineTests.py
; running that file will hopefully illustrate what I'm doing.All these new functions need to be tested before this PR is complete and ready for merge.
How to read test partitioning syntax
Tests are collected in groups to AND together, and groups to OR together, and these groupings are expressed in lists. For example, a partition expressed as
[[0,3], [1], [7]]
means (0 AND 3) OR (1) OR (7). Note not all tests need be used in a given partition.