🔨 Add support for user-expressions
#742
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoose77
changed the title
user-expressions
agoose77
force-pushed
the
agoose77/wip-user-expressions
branch
from
ae9f2b9
to
1348a94
Compare
agoose77
changed the title
user-expressionsuser-expressions
1 task
|
Hmm, I’m not sure if I have those cycles actually! I haven’t worked on R for a long time and forgot a lot of things about this code base. Maybe I’ll get around to it, but it would be best if someone actually still doing R could look at this. |
|
Thanks @flying-sheep! Do you know of anyone off-hand to recommend following this up with? Perhaps @MichaelChirico? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@flying-sheep nice to stumble across you in a different context!
We've had a couple of requests from our users for user-expressions support in the MyST space (Jupyter Book or MyST-MD):
I'm sure there are more that I've been unable to find.
We use this little-known part of the Jupyter kernel protocol to execute "expressions" (c.f. https://mystmd.org/guide/quickstart-jupyter-lab-myst#inline-expressions), e.g.
The result of 1 + 2 is {eval}`1 + 2`.In the context of the R kernel, given that R doesn't have statements (only expressions), this distinction is not that useful, but there are additional differences between code execution and user-expressions, such as ignoring display outputs (only taking object formatter display messages).
I'm not an R user, but I've hacked together a prototype that I think works for basic
text/plaininterpolation. Do you have any spare cycles to help me tidy this up for merging? I'm not au-fait with e.g. linters/formatters, good-practice in R code, etc. I wouldn't consider this code production ready given my R credentials.Thanks!
Closes #678