-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/80 export students data #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that it didn't work, but I have found that the URLs that you have given are incorrect. I will add the correct ones in this comment, so that other reviewers can try them out directly.
http://127.0.0.1:8000/api/export/pdf/students
http://127.0.0.1:8000/api/export/csv/students
Apart from that, works as expected. Good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FelixoGudiel for the correct urls. Both the excel and the pdf download correctly. Well done.
Remember to update from develop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting your feature so early, but can you please add the Excel export, and query parameters, as well as in the donations task?
Sorry about that, It was implemented in last week's issue, but I forgot to add it in the ones of this week.
Thanks for the comments, first of all, sorry for the urls I do not know how it could have happened and secondly I do the new without any problem the only thing is that in donations the parameters were around two dates in this case that filtering would be the most appropriate |
Of course! In this case, it would be great to have a filter based on the name, surname, family, nationality, if it's a morning student or even the lesson on which the student is enrolled if you think it's possible. |
…nto feature/80-export-students-data
…ISPP-G5/NexONG_Backend into feature/80-export-students-data
I have finished implementing the export in Pdf and excel of students with the filters. You can filter to test by adding the fields name, surname, nationality, family and is a moning student. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! I think that the feature is much better now!
However, can you consider also adding a filter considering the current education year and the status? Because I believe that these are important filters when in the future the app contains a lot of data.
Also, I tried this query http://127.0.0.1:8000/api/export/pdf/students?isamorningstudent=True and seems it is not working for me.
Finally, Can you try to add the query to the document name as the feature of last week?
Thank you so much!
Thank you for your comment, I will immediately add the two you have told me to filter in the query. The url of is a moning student does not work because I have put it only morning because I consider the name too long for a query. I also implement the name in the title without any problem. |
I have just implemented the 2 new filters with their correct filenames. These are an example to test, but you can try all the options: |
Seems like the second link does not work. I would think about changing all the enums to a pattern like CUARTO_PRIMARIA instead of CUARTO PRIMARIA so that it can be understood as a single URL. |
The problem is with GitHub because it interprets it as outside the URL, but if you copy it and paste it in the browser there is no problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. Everythong seems in order then!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The feature works like a charm. Good work!
…nto feature/80-export-students-data
…into feature/80-export-students-data
…ISPP-G5/NexONG_Backend into feature/80-export-students-data
aab938b
I have implemented the export of students in both pdf and csv format.
You can access the urls :
http://127.0.0.1:8000/export/csv/students and http://127.0.0.1:8000/export/pdf/students to try it out.
Any suggestions for changes let me know in the comments.