Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix/148-fix-user-roles #149

Merged
merged 3 commits into from
Apr 5, 2024
Merged

hotfix/148-fix-user-roles #149

merged 3 commits into from
Apr 5, 2024

Conversation

JuanluRM
Copy link
Contributor

@JuanluRM JuanluRM commented Apr 4, 2024

Changed permissions on roles so Admins can change roles and the owners of the roles can put and post their own roles.

@JuanluRM JuanluRM added the bug Something isn't working label Apr 4, 2024
@JuanluRM JuanluRM added this to the Sprint 3 milestone Apr 4, 2024
@JuanluRM JuanluRM self-assigned this Apr 4, 2024
@JuanluRM JuanluRM linked an issue Apr 4, 2024 that may be closed by this pull request
Fix user roles #148
Closed
pabpercab1
pabpercab1 reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor

@pabpercab1 pabpercab1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, it works like it was expected. Many thanks for working on this issue. Only remember, if it is feasible to fix the permission of the HomeDocument model, that at the moment everyone can edit, and also you must be logged in to see.

@pabpercab1 pabpercab1 self-requested a review April 4, 2024 20:59
pabpercab1
pabpercab1 approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@pabpercab1 pabpercab1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

auroranavas
auroranavas approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@auroranavas auroranavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the issue quickly!

MRomalde
MRomalde approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@MRomalde MRomalde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!! All seems to work properly!

@MRomalde MRomalde merged commit b404543 into develop Apr 5, 2024
6 checks passed
@MRomalde MRomalde deleted the hotfix/148-fix-user-roles branch April 5, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MRomalde MRomalde MRomalde approved these changes

@pabpercab1 pabpercab1 pabpercab1 approved these changes

@auroranavas auroranavas auroranavas approved these changes

Assignees

@JuanluRM JuanluRM

Labels
bug Something isn't working
Projects
Sprint 3
Status: Done
Milestone
Sprint 3
Development

Successfully merging this pull request may close these issues.

Fix user roles
4 participants
@JuanluRM @MRomalde @pabpercab1 @auroranavas