Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/59-model changes #63

Merged
merged 6 commits into from
Mar 2, 2024
Merged

Hotfix/59-model changes #63

merged 6 commits into from
Mar 2, 2024

Conversation

pabpercab1
Copy link
Contributor

In this update to the model, the latest changes proposed by the NGO were added. These changes can be found in the UML diagram in the common folder.

@pabpercab1 pabpercab1 added bug Something isn't working enhancement New feature or request labels Mar 1, 2024
@pabpercab1 pabpercab1 added this to the Sprint 1 milestone Mar 1, 2024
@pabpercab1 pabpercab1 self-assigned this Mar 1, 2024
@pabpercab1 pabpercab1 linked an issue Mar 1, 2024 that may be closed by this pull request
Models changes in the app #61
Closed
@pabpercab1 pabpercab1 requested review from auroranavas, MRomalde, Ahydul and manortbla and removed request for MRomalde March 1, 2024 20:28
manortbla
manortbla previously approved these changes Mar 2, 2024
View reviewed changes
Copy link
Contributor

@manortbla manortbla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reviewing the new models according to the UML created after the meeting with "Manos Abiertas", everything is correct. Good job.

auroranavas
auroranavas previously approved these changes Mar 2, 2024
View reviewed changes
Copy link
Contributor

@auroranavas auroranavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good and works. Let's keep up the good work!

Ahydul
Ahydul requested changes Mar 2, 2024
View reviewed changes
Copy link
Contributor

@Ahydul Ahydul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. One little thing is that in the class Event, the defaut=0 parameter in capacity must be removed, it creates problems in the serializer

@auroranavas auroranavas requested review from FelixoGudiel and removed request for manortbla March 2, 2024 11:55
FelixoGudiel
FelixoGudiel approved these changes Mar 2, 2024
View reviewed changes
Copy link
Contributor

@FelixoGudiel FelixoGudiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine! This model should reflect better the expected functionalities for the app.

Ahydul
Ahydul approved these changes Mar 2, 2024
View reviewed changes
Copy link
Contributor

@Ahydul Ahydul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is correct

@auroranavas auroranavas merged commit 053cb01 into develop Mar 2, 2024
6 checks passed
@pabpercab1 pabpercab1 deleted the hotfix/59-model-changes branch April 4, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ahydul Ahydul Ahydul approved these changes

@FelixoGudiel FelixoGudiel FelixoGudiel approved these changes

@auroranavas auroranavas auroranavas approved these changes

@manortbla manortbla manortbla left review comments

Assignees

@pabpercab1 pabpercab1

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
Sprint 1
Development

Successfully merging this pull request may close these issues.

Models changes in the app
5 participants
@pabpercab1 @Ahydul @manortbla @FelixoGudiel @auroranavas