Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaces f64 and i64 with FloatType and IntType. #113

Merged
merged 2 commits into from
Nov 21, 2022
Merged

Replaces f64 and i64 with FloatType and IntType. #113

merged 2 commits into from
Nov 21, 2022

Conversation

NatanFreeman
Copy link
Contributor

Replaces use of f64 and i64 literal syntax in favour of custom FloatType and IntType. This is done to make changing FloatType's and IntType's definitions more seamless. As one might do in relation to issues like #111 .

ISibboI
ISibboI requested changes Nov 21, 2022
View reviewed changes
Copy link
Owner

@ISibboI ISibboI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great! Could you still format the code?

@NatanFreeman
Copy link
Contributor Author

I ran cargo +nightly fmt --all. It didn't do much but it should now be formatted properly.

ISibboI
ISibboI approved these changes Nov 21, 2022
View reviewed changes
Copy link
Owner

@ISibboI ISibboI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks!

@ISibboI ISibboI merged commit 040a192 into ISibboI:main Nov 21, 2022
@NatanFreeman
Copy link
Contributor Author

🦀🦀🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ISibboI ISibboI ISibboI approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NatanFreeman @ISibboI