-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service/Node resources in frontend #2998
Service/Node resources in frontend #2998
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2998 +/- ##
========================================
- Coverage 79.6% 79.6% -0.1%
========================================
Files 688 688
Lines 28694 28694
Branches 3701 3701
========================================
- Hits 22864 22860 -4
- Misses 5017 5018 +1
- Partials 813 816 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice first step!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Nice
Since reservation <= limit
- shouldn't we read first reservation and then limit?
- I also think it would be nice to have a description of each term displayed e.g. when hover. @sanderegg had a nice one in his PR
What do these changes do?
Request and display resources (RAM is shown in gigabytes (updated after recording animations)):
/service/resources
/node/resources
Bonus:
Related issue/s
How to test
Checklist