Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service/Node resources in frontend #2998

Merged
merged 9 commits into from
Apr 22, 2022

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Apr 22, 2022

What do these changes do?

Request and display resources (RAM is shown in gigabytes (updated after recording animations)):

  • /service/resources
    Service resources

  • /node/resources
    NodeResources

Bonus:

  • Fix Colleen Clancys

Related issue/s

How to test

Checklist

@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Apr 22, 2022
@odeimaiz odeimaiz added this to the Macarons milestone Apr 22, 2022
@odeimaiz odeimaiz self-assigned this Apr 22, 2022
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #2998 (ac0a06f) into master (98d6049) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2998     +/-   ##
========================================
- Coverage    79.6%   79.6%   -0.1%     
========================================
  Files         688     688             
  Lines       28694   28694             
  Branches     3701    3701             
========================================
- Hits        22864   22860      -4     
- Misses       5017    5018      +1     
- Partials      813     816      +3     
Flag Coverage Δ
integrationtests 65.6% <ø> (+<0.1%) ⬆️
unittests 75.3% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rvice_datcore_adapter/utils/requests_decorators.py 68.4% <0.0%> (-10.6%) ⬇️
...ector_v2/modules/comp_scheduler/background_task.py 83.3% <0.0%> (-8.4%) ⬇️
...c/simcore_service_catalog/core/background_tasks.py 66.3% <0.0%> (-3.2%) ⬇️
...rector_v2/modules/comp_scheduler/base_scheduler.py 86.7% <0.0%> (-1.9%) ⬇️
...e_service_director_v2/modules/dask_clients_pool.py 92.4% <0.0%> (-1.6%) ⬇️
.../director/src/simcore_service_director/producer.py 61.9% <0.0%> (-0.7%) ⬇️
..._director_v2/modules/dynamic_sidecar/docker_api.py 86.7% <0.0%> (-0.5%) ⬇️
...ector_v2/modules/dynamic_sidecar/scheduler/task.py 81.9% <0.0%> (+0.4%) ⬆️
.../simcore_service_catalog/services/access_rights.py 81.2% <0.0%> (+2.5%) ⬆️
.../simcore_service_catalog/db/repositories/groups.py 72.9% <0.0%> (+2.7%) ⬆️
... and 3 more

@odeimaiz odeimaiz marked this pull request as ready for review April 22, 2022 10:19
@odeimaiz odeimaiz changed the title WIP: Service/Node resources in frontend Service/Node resources in frontend Apr 22, 2022
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice first step!

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Nice

Since reservation <= limit

  • shouldn't we read first reservation and then limit?
  • I also think it would be nice to have a description of each term displayed e.g. when hover. @sanderegg had a nice one in his PR

@odeimaiz odeimaiz merged commit 6671e1a into ITISFoundation:master Apr 22, 2022
@odeimaiz odeimaiz deleted the feature/minor-fixes-ii branch August 20, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants