-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Storage: allow creation of multipart presigned upload links #3021
Merged
sanderegg
merged 59 commits into
ITISFoundation:master
from
sanderegg:enhancement/allow_multipart_links
Jul 6, 2022
Merged
✨ Storage: allow creation of multipart presigned upload links #3021
sanderegg
merged 59 commits into
ITISFoundation:master
from
sanderegg:enhancement/allow_multipart_links
Jul 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3021 +/- ##
========================================
+ Coverage 80.4% 81.3% +0.8%
========================================
Files 722 723 +1
Lines 30705 30933 +228
Branches 3971 4001 +30
========================================
+ Hits 24706 25164 +458
+ Misses 5206 4961 -245
- Partials 793 808 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sanderegg
force-pushed
the
enhancement/allow_multipart_links
branch
2 times, most recently
from
May 6, 2022 14:30
cc813e6
to
0563ecf
Compare
sanderegg
force-pushed
the
enhancement/allow_multipart_links
branch
3 times, most recently
from
May 19, 2022 11:39
23cb29f
to
c32a2dd
Compare
pcrespov
reviewed
May 19, 2022
sanderegg
force-pushed
the
enhancement/allow_multipart_links
branch
4 times, most recently
from
May 25, 2022 10:17
d9616e2
to
0b10a96
Compare
sanderegg
force-pushed
the
enhancement/allow_multipart_links
branch
from
May 29, 2022 21:34
0b10a96
to
91de02b
Compare
sanderegg
force-pushed
the
enhancement/allow_multipart_links
branch
from
May 30, 2022 12:54
177c324
to
392f425
Compare
sanderegg
changed the title
✨ Add creation of multipart upload links
✨ Refactoring of storage/allow creation of multipart presigned upload links
May 30, 2022
sanderegg
force-pushed
the
enhancement/allow_multipart_links
branch
from
June 1, 2022 16:45
b930aab
to
40b4773
Compare
Please retry analysis of this Pull-Request directly on SonarCloud. |
2 tasks
sanderegg
force-pushed
the
enhancement/allow_multipart_links
branch
4 times, most recently
from
June 9, 2022 05:40
502a42d
to
81e43ea
Compare
sanderegg
force-pushed
the
enhancement/allow_multipart_links
branch
3 times, most recently
from
June 13, 2022 10:00
1c3b411
to
c51a157
Compare
commit 9ac413c43a69b1e901fbfc26d5290ea9215701e5 Author: sanderegg <35365065+sanderegg@users.noreply.github.com> Date: Mon Jul 4 23:07:29 2022 +0200 all simcore-sdk tests passing commit 132df992bc299e5cc60c7e98e527876d3c7b4d91 Author: sanderegg <35365065+sanderegg@users.noreply.github.com> Date: Mon Jul 4 22:35:47 2022 +0200 remove config come settings test changed
change to STORAGE_HOST, STORAGE_PORT
sanderegg
force-pushed
the
enhancement/allow_multipart_links
branch
from
July 6, 2022 08:57
ad656f3
to
e379255
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR brings the long awaited so-called multipart upload in the storage micro-service. Multipart uploads allow to upload a file of max 5 TB to S3 by chunking the data in smaller pieces.
Highlights:
Upload process
PUT /v0/locations/{location_id}/files/{file_id}
now take an optional query parameterfile_size
file_size
is not set, then the request will behave as before (backward compatible - ONLY for legacy dynamic services, will be deprecated as soon as these services are removed)file_size
is set with 0, then the new data structure is returned but still a single link (limited to 5Gb) is returnedfile_size
is set to the real size of the file, the new data structure is returned with a number of links for upload (S3 allows to go multipart from 10MB upwards)POST /v0/locations/{location_id}/files/{file_id}:complete
allows to tell storage that the file upload was completedfuture_id
POST /locations/{location_id}/files/{file_id}:complete/futures/{future_id}
allows to know when the completion task is finishedMultipart uploads:
file_meta_data
table got 1 additional column calledupload_id
Related issue/s
How to test
Checklist