-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Personalized resources: Allow override of computational service needed resources (⚠️ devops) #3989
✨ Personalized resources: Allow override of computational service needed resources (⚠️ devops) #3989
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3989 +/- ##
=========================================
- Coverage 83.0% 68.9% -14.1%
=========================================
Files 944 579 -365
Lines 40778 23817 -16961
Branches 848 539 -309
=========================================
- Hits 33862 16421 -17441
- Misses 6706 7271 +565
+ Partials 210 125 -85
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ef791f1
to
f5eb1c2
Compare
3ea4c7f
to
485e70c
Compare
c3e0e1e
to
1cdf4d8
Compare
services/catalog/src/simcore_service_catalog/api/routes/services_resources.py
Show resolved
Hide resolved
services/dask-sidecar/src/simcore_service_dask_sidecar/computational_sidecar/docker_utils.py
Show resolved
Hide resolved
services/dask-sidecar/src/simcore_service_dask_sidecar/utils.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This will be very useful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good to me
f93dfdb
to
2c4df34
Compare
8dc8be7
to
3be0dbd
Compare
Code Climate has analyzed commit 52348da and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
This PR will bring the following:
TARGET_MPI_NODE_CPU_COUNT
(service_specifications
table to allow resources overrideDetails:
replaces #3971
mpi
flag as resource (catalog API /resources endpoint will not return MPI anymore)services_specifications
Related issue/s
fixes ITISFoundation/osparc-issues#618
How to test
Checklist