Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Personalized limits: add table per service? #4294

Conversation

sanderegg
Copy link
Member

What do these changes do?

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg added the a:database associated to postgres service and postgres-database package label Jun 1, 2023
@sanderegg sanderegg added this to the Pastel de Nata milestone Jun 1, 2023
@sanderegg sanderegg self-assigned this Jun 1, 2023
@codeclimate
Copy link

codeclimate bot commented Jun 1, 2023

Code Climate has analyzed commit e3f4b61 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #4294 (e3f4b61) into master (57bba7e) will increase coverage by 2.9%.
The diff coverage is 0.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4294     +/-   ##
========================================
+ Coverage    83.8%   86.8%   +2.9%     
========================================
  Files         976     839    -137     
  Lines       41981   37205   -4776     
  Branches      965     426    -539     
========================================
- Hits        35221   32311   -2910     
+ Misses       6539    4788   -1751     
+ Partials      221     106    -115     
Flag Coverage Δ
integrationtests 68.8% <ø> (-0.1%) ⬇️
unittests 83.3% <0.0%> (+1.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...res_database/models/services_max_specifications.py 0.0% <0.0%> (ø)

... and 211 files with indirect coverage changes

@sanderegg sanderegg closed this Jun 8, 2023
@sanderegg sanderegg deleted the enhancement/setup-max-resources-service-table branch June 8, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:database associated to postgres service and postgres-database package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant