Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 GC enabling WEBSERVER_SOCKETIO by default #4311

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jun 5, 2023

What do these changes do?

The WEBSERVER_SOCKETIO plugin was disabled in the GC, which raised an error when trying to remove_disconnected_user_resources.

Traceback (most recent call last):
  File "/home/scu/.venv/lib/python3.10/site-packages/simcore_service_webserver/garbage_collector_task.py", line 74, in collect_garbage_periodically
    await collect_garbage(app)
  File "/home/scu/.venv/lib/python3.10/site-packages/simcore_service_webserver/garbage_collector_core.py", line 80, in collect_garbage
    await remove_disconnected_user_resources(registry, app)
  File "/home/scu/.venv/lib/python3.10/site-packages/simcore_service_webserver/garbage_collector_core.py", line 198, in remove_disconnected_user_resources
    await remove_project_dynamic_services(
  File "/home/scu/.venv/lib/python3.10/site-packages/simcore_service_webserver/projects/projects_api.py", line 1021, in remove_project_dynamic_services
    async with lock_with_notification(
  File "/usr/local/lib/python3.10/contextlib.py", line 199, in __aenter__
    return await anext(self.gen)
  File "/home/scu/.venv/lib/python3.10/site-packages/simcore_service_webserver/projects/projects_api.py", line 1161, in lock_with_notification
    await retrieve_and_notify_project_locked_state(user_id, project_uuid, app)
  File "/home/scu/.venv/lib/python3.10/site-packages/simcore_service_webserver/projects/projects_api.py", line 1113, in retrieve_and_notify_project_locked_state
    await notify_project_state_update(
  File "/home/scu/.venv/lib/python3.10/site-packages/simcore_service_webserver/projects/projects_api.py", line 1072, in notify_project_state_update
    await send_group_messages(app, room, messages)
  File "/home/scu/.venv/lib/python3.10/site-packages/simcore_service_webserver/socketio/messages.py", line 78, in send_group_messages
    sio: AsyncServer = get_socket_server(app)
  File "/home/scu/.venv/lib/python3.10/site-packages/simcore_service_webserver/socketio/_utils.py", line 14, in get_socket_server
    return app[APP_CLIENT_SOCKET_SERVER_KEY]
  File "/home/scu/.venv/lib/python3.10/site-packages/aiohttp/web_app.py", line 186, in __getitem__
    return self._state[key]
KeyError: 'simcore_service_webserver.socketio._utils.socketio_socketio'

Related issue/s

How to test

DevOps Checklist

@GitHK GitHK marked this pull request as ready for review June 5, 2023 08:17
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #4311 (13549ee) into master (6887666) will decrease coverage by 0.4%.
The diff coverage is n/a.

❗ Current head 13549ee differs from pull request most recent head 0e13cb5. Consider uploading reports for the commit 0e13cb5 to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4311     +/-   ##
========================================
- Coverage    85.5%   85.2%   -0.4%     
========================================
  Files         965     926     -39     
  Lines       41138   38940   -2198     
  Branches      978     978             
========================================
- Hits        35188   33188   -2000     
+ Misses       5728    5530    -198     
  Partials      222     222             
Flag Coverage Δ
integrationtests 66.2% <ø> (-1.8%) ⬇️
unittests 82.8% <ø> (-0.3%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 51 files with indirect coverage changes

@GitHK GitHK self-assigned this Jun 5, 2023
@GitHK GitHK added High Priority a totally crucial bug/feature to be fixed asap changelog:🐛bugfix labels Jun 5, 2023
@GitHK GitHK added this to the Watermelon milestone Jun 5, 2023
.env-devel Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Jun 5, 2023

Code Climate has analyzed commit 0e13cb5 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Jun 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@GitHK GitHK requested a review from pcrespov June 5, 2023 09:20
@GitHK GitHK enabled auto-merge (squash) June 5, 2023 09:20
@sanderegg sanderegg disabled auto-merge June 5, 2023 09:23
@sanderegg sanderegg merged commit e44b0d3 into ITISFoundation:master Jun 5, 2023
@GitHK GitHK deleted the pr-osparc-fix-gc-settings-key-error branch June 5, 2023 09:23
@GitHK GitHK mentioned this pull request Jun 7, 2023
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority a totally crucial bug/feature to be fixed asap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants