-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 GC enabling WEBSERVER_SOCKETIO
by default
#4311
🐛 GC enabling WEBSERVER_SOCKETIO
by default
#4311
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4311 +/- ##
========================================
- Coverage 85.5% 85.2% -0.4%
========================================
Files 965 926 -39
Lines 41138 38940 -2198
Branches 978 978
========================================
- Hits 35188 33188 -2000
+ Misses 5728 5530 -198
Partials 222 222
Flags with carried forward coverage won't be shown. Click here to find out more. |
Code Climate has analyzed commit 0e13cb5 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
What do these changes do?
The
WEBSERVER_SOCKETIO
plugin was disabled in the GC, which raised an error when trying toremove_disconnected_user_resources
.Related issue/s
How to test
DevOps Checklist