Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ webserver: fixes mypy issues in exporter plugin #4339

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jun 8, 2023

What do these changes do?

Addresses remaining issues with mypy in webserver's exporter module.

Related issue/s

How to test

DevOps Checklist

@GitHK GitHK self-assigned this Jun 8, 2023
@GitHK GitHK added a:webserver issue related to the webserver service t:maintenance Some planned maintenance work labels Jun 8, 2023
@GitHK GitHK added this to the Watermelon milestone Jun 8, 2023
@GitHK GitHK changed the title 🐛 Fixes mypy in webserver's exporter module ♻️ webserver: fixes mypy issues in exporter plugin Jun 8, 2023
@GitHK GitHK marked this pull request as ready for review June 8, 2023 12:54
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #4339 (afb8f70) into master (d3a78c6) will decrease coverage by 6.9%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4339      +/-   ##
=========================================
- Coverage    85.6%   78.8%    -6.9%     
=========================================
  Files         978     392     -586     
  Lines       41979   20415   -21564     
  Branches      993     173     -820     
=========================================
- Hits        35968   16089   -19879     
+ Misses       5787    4277    -1510     
+ Partials      224      49     -175     
Flag Coverage Δ
integrationtests 61.2% <62.5%> (-6.8%) ⬇️
unittests 86.2% <75.0%> (+3.0%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...er/exporter/_formatter/xlsx/dataset_description.py 100.0% <ø> (ø)
...core_service_webserver/exporter/_formatter/_sds.py 56.9% <100.0%> (+0.6%) ⬆️
...erver/exporter/_formatter/xlsx/code_description.py 100.0% <100.0%> (ø)
...bserver/exporter/_formatter/xlsx/core/xlsx_base.py 92.3% <100.0%> (ø)
...ver/exporter/_formatter/xlsx/directory_manifest.py 100.0% <100.0%> (ø)
...rc/simcore_service_webserver/exporter/_handlers.py 97.2% <100.0%> (+<0.1%) ⬆️

... and 682 files with indirect coverage changes

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@pcrespov pcrespov enabled auto-merge (squash) June 8, 2023 17:17
@codeclimate
Copy link

codeclimate bot commented Jun 9, 2023

Code Climate has analyzed commit afb8f70 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Jun 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants