Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor od_disaggregate III #38

Merged
merged 6 commits into from
Dec 5, 2021
Merged

Refactor od_disaggregate III #38

merged 6 commits into from
Dec 5, 2021

Conversation

Robinlovelace
Copy link
Member

No description provided.

@Robinlovelace Robinlovelace marked this pull request as draft December 5, 2021 08:27
@Robinlovelace Robinlovelace changed the title od_nrows() Refactor od_disaggregate III Dec 5, 2021
@Robinlovelace Robinlovelace mentioned this pull request Dec 5, 2021
Open
Robinlovelace and others added 2 commits December 5, 2021 11:21
@Robinlovelace
Add od_disag args to od_jitter for #39 (#40)
4109071 
* Add od_disag args to od_jitter for #39

* Use od_dissaggrate backend for #39
@Robinlovelace
Update news
1f08df7
@Robinlovelace Robinlovelace marked this pull request as ready for review December 5, 2021 11:23
@Robinlovelace
Copy link
Member Author

Lots of refactoring. There is scope for more refactoring of od_jitter() but it works and od_disaggregate() which has nicer code now does the work where possible. Please take a gander if you get a chance Nathanael, relevant for abstr.

@Robinlovelace
Copy link
Member Author

This hasn't been reviewed but merging now to keep this package moving forward. Happy to make any changes based on review comments.

@Robinlovelace Robinlovelace merged commit b0087b9 into main Dec 5, 2021
@Robinlovelace Robinlovelace deleted the disagrefactor3 branch December 5, 2021 11:28
natesheehan
natesheehan reviewed Dec 5, 2021
View reviewed changes
Copy link
Collaborator

@natesheehan natesheehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is looking good, nice Sunday tidy up! I've downloaded the latest version of od from github and seems like no breaking changes for abstr

@Robinlovelace
Copy link
Member Author

Fantastic. Thanks for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natesheehan natesheehan natesheehan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Robinlovelace @natesheehan