Refactor od_disaggregate III#38
Merged
Robinlovelace merged 6 commits intomainfrom Dec 5, 2021
Merged
Conversation
Member
Author
|
Lots of refactoring. There is scope for more refactoring of |
Member
Author
|
This hasn't been reviewed but merging now to keep this package moving forward. Happy to make any changes based on review comments. |
natesheehan
reviewed
Dec 5, 2021
Collaborator
natesheehan
left a comment
natesheehan
left a comment
There was a problem hiding this comment.
code is looking good, nice Sunday tidy up! I've downloaded the latest version of od from github and seems like no breaking changes for abstr
Member
Author
|
Fantastic. Thanks for testing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.