Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit with error if any pact push operations fail #149

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

dantb
Copy link
Contributor

@dantb dantb commented Oct 7, 2019

This affects pactPush and pactPublish. Just a suggestion really - it should maybe be considered a breaking change.

Motivation for this is that someone in our team whose name rhymes with spaniel accidentally deleted the pact.sbt for a service so the build wasn't publishing pacts for 2 months. Luckily none of its pacts were changed in that time. No-one noticed as you get this logged but the pactPublish command exits happily -

Validation error
Pact broker address not set, you need to add the following line to you SBT file:
pactBrokerAddress := "http://pactbroker.myserver.com"

@davesmith00000
Copy link
Contributor

Lets review this change in the morning, looks like it's probably fine but I'd like to read it with fresh eyes.

@dantb dantb merged commit 1e4103f into master Oct 10, 2019
@dantb dantb deleted the exit-error-when-pact-publish-fails branch July 6, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants