Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ITensors] Start organizing into submodules #1400

Merged
merged 19 commits into from
Apr 29, 2024
Merged

Conversation

mtfishman
Copy link
Member

@mtfishman mtfishman commented Apr 28, 2024

This moves some code in ITensors into submodules. The goal is to attempt to split the library into independent parts, with an eye towards deciding what will go into the future ITensorMPS.jl package, and what else might get split off from ITensors.jl.

For example, I've moved the lattice construction code into ITensors.ITensorMPS since it is more related to the MPS code, and put the definition of the QN type into a submodule ITensors.QuantumNumbers. Additionally, I've started the process of splitting off the op, state, and val system into a submodule ITensors.SiteTypes, since it is possible that we might want to split it off from ITensors.jl and consider that code to be more of an add-on on top of ITensors.jl rather than part of the core ITensors.jl library. That code will be used by both ITensorMPS.jl and ITensorNetworks.jl, so we could think of it as sitting in between ITensors.jl and those packages.

@emstoudenmire

@emstoudenmire
Copy link
Collaborator

These sound like welcome changes. We can keep reducing the "surface area" between these different libraries.

@mtfishman mtfishman merged commit ff6a871 into main Apr 29, 2024
19 checks passed
@mtfishman mtfishman deleted the ITensorMPS_reorganization branch April 29, 2024 01:15
@mtfishman mtfishman changed the title [ITensors] Code reorganization [ITensors] Start organizing into submodules Apr 29, 2024
ogauthe pushed a commit to ogauthe/ITensors.jl that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants