-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ITensors] Start organizing into submodules #1400
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These sound like welcome changes. We can keep reducing the "surface area" between these different libraries. |
mtfishman
changed the title
[ITensors] Code reorganization
[ITensors] Start organizing into submodules
Apr 29, 2024
ogauthe
pushed a commit
to ogauthe/ITensors.jl
that referenced
this pull request
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves some code in
ITensors
into submodules. The goal is to attempt to split the library into independent parts, with an eye towards deciding what will go into the futureITensorMPS.jl
package, and what else might get split off fromITensors.jl
.For example, I've moved the lattice construction code into
ITensors.ITensorMPS
since it is more related to the MPS code, and put the definition of theQN
type into a submoduleITensors.QuantumNumbers
. Additionally, I've started the process of splitting off theop
,state
, andval
system into a submoduleITensors.SiteTypes
, since it is possible that we might want to split it off fromITensors.jl
and consider that code to be more of an add-on on top ofITensors.jl
rather than part of the coreITensors.jl
library. That code will be used by bothITensorMPS.jl
andITensorNetworks.jl
, so we could think of it as sitting in betweenITensors.jl
and those packages.@emstoudenmire