Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MPO*MPS, MPO*MPO for system sizes 1 and 2 #572

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Conversation

mtfishman
Copy link
Member

This fixes #544.

@mtfishman mtfishman merged commit 2ec0379 into master Feb 3, 2021
@mtfishman mtfishman deleted the small_mpo branch February 3, 2021 23:07
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2021

Benchmark result

Judge result

Benchmark Report for /home/runner/work/ITensors.jl/ITensors.jl

Job Properties

  • Time of benchmarks:
    • Target: 3 Feb 2021 - 23:22
    • Baseline: 3 Feb 2021 - 23:30
  • Package commits:
    • Target: 67d05b
    • Baseline: 2ec037
  • Julia commits:
    • Target: 44fa15
    • Baseline: 44fa15
  • Julia command flags:
    • Target: None
    • Baseline: None
  • Environment variables:
    • Target: None
    • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["contract", "matmul_80"] 1.12 (5%) ❌ 1.00 (1%)
["indexset", "filter", "function"] 0.00 (5%) ✅ 0.00 (1%) ✅
["indexset", "filter", "kwargs"] 0.00 (5%) ✅ 0.05 (1%) ✅
["indexset", "filter", "order_kwargs"] 0.88 (5%) ✅ 1.00 (1%)
["indexset", "uniqueinds", "order_3_inputs"] 0.78 (5%) ✅ 1.00 (1%)
["indexset", "uniqueinds", "order_filter_not_tags"] 0.86 (5%) ✅ 1.00 (1%)
["op", "op"] 0.87 (5%) ✅ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["autompo"]
  • ["contract"]
  • ["dmrg"]
  • ["indexset", "constructor"]
  • ["indexset", "filter"]
  • ["indexset", "uniqueinds"]
  • ["inplace"]
  • ["op"]
  • ["tagset"]

Julia versioninfo

Target

Julia Version 1.4.2
Commit 44fa15b150* (2020-05-23 18:35 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.5 LTS
  uname: Linux 5.4.0-1036-azure #38~18.04.1-Ubuntu SMP Wed Jan 6 18:26:30 UTC 2021 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2095 MHz      54464 s          0 s       5206 s      32495 s          0 s
       #2  2095 MHz      48677 s          0 s       7372 s      36373 s          0 s
       
  Memory: 6.791393280029297 GB (2258.6640625 MB free)
  Uptime: 940.0 sec
  Load Avg:  1.22998046875  1.26611328125  0.896484375
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, skylake)

Baseline

Julia Version 1.4.2
Commit 44fa15b150* (2020-05-23 18:35 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.5 LTS
  uname: Linux 5.4.0-1036-azure #38~18.04.1-Ubuntu SMP Wed Jan 6 18:26:30 UTC 2021 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2095 MHz      91265 s          0 s       8300 s      42226 s          0 s
       #2  2095 MHz      67611 s          0 s       9365 s      65010 s          0 s
       
  Memory: 6.791393280029297 GB (2275.5 MB free)
  Uptime: 1437.0 sec
  Load Avg:  1.06689453125  1.2353515625  1.04931640625
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, skylake)

Target result

Benchmark Report for /home/runner/work/ITensors.jl/ITensors.jl

Job Properties

  • Time of benchmark: 3 Feb 2021 - 23:22
  • Package commit: 67d05b
  • Julia commit: 44fa15
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["autompo", "Quartic Hamiltonian"] 8.875 s (5%) 597.246 ms 1.78 GiB (1%) 37694072
["autompo", "Quartic QN Hamiltonian"] 18.402 s (5%) 3.298 s 9.67 GiB (1%) 105729131
["contract", "heff_2site"] 6.719 ms (5%) 19.41 MiB (1%) 258
["contract", "matmul_100"] 52.502 μs (5%) 80.44 KiB (1%) 30
["contract", "matmul_20"] 2.850 μs (5%) 5.48 KiB (1%) 29
["contract", "matmul_40"] 8.300 μs (5%) 14.86 KiB (1%) 29
["contract", "matmul_60"] 20.701 μs (5%) 30.44 KiB (1%) 30
["contract", "matmul_80"] 31.801 μs (5%) 52.31 KiB (1%) 30
["contract", "matmul_inplace_100"] 48.501 μs (5%) 1.38 KiB (1%) 18
["contract", "matmul_inplace_20"] 1.430 μs (5%) 1.38 KiB (1%) 18
["contract", "matmul_inplace_40"] 5.560 μs (5%) 1.38 KiB (1%) 18
["contract", "matmul_inplace_60"] 15.500 μs (5%) 1.38 KiB (1%) 18
["contract", "matmul_inplace_80"] 24.701 μs (5%) 1.38 KiB (1%) 18
["dmrg", "1d_S=1_heisenberg"] 26.224 s (5%) 2.462 s 38.55 GiB (1%) 2553806
["dmrg", "1d_S=1_heisenberg_qn"] 13.876 s (5%) 1.766 s 12.36 GiB (1%) 102368146
["indexset", "constructor", "function"] 571.282 ns (5%) 1.97 KiB (1%) 8
["indexset", "filter", "function"] 1.180 μs (5%) 2.56 KiB (1%) 4
["indexset", "filter", "function_order"] 37.262 ns (5%) 224 bytes (1%) 1
["indexset", "filter", "kwargs"] 322.289 ns (5%) 1.30 KiB (1%) 4
["indexset", "filter", "order_kwargs"] 21.465 ns (5%) 112 bytes (1%) 1
["indexset", "uniqueinds", "3_inputs"] 606.271 ns (5%) 864 bytes (1%) 5
["indexset", "uniqueinds", "filter_not_tags"] 638.860 ns (5%) 1.09 KiB (1%) 9
["indexset", "uniqueinds", "filter_tags"] 531.164 ns (5%) 864 bytes (1%) 5
["indexset", "uniqueinds", "nofilter0"] 3.300 μs (5%) 80 bytes (1%) 1
["indexset", "uniqueinds", "nofilter2"] 593.356 ns (5%) 1.17 KiB (1%) 6
["indexset", "uniqueinds", "order0"] 94.746 ns (5%)
["indexset", "uniqueinds", "order2"] 133.012 ns (5%) 224 bytes (1%) 1
["indexset", "uniqueinds", "order_3_inputs"] 169.030 ns (5%) 112 bytes (1%) 1
["indexset", "uniqueinds", "order_filter_not_tags"] 204.242 ns (5%) 368 bytes (1%) 5
["indexset", "uniqueinds", "order_filter_tags"] 83.686 ns (5%) 112 bytes (1%) 1
["inplace", "axpy!"] 12.400 μs (5%) 2.11 KiB (1%) 33
["op", "op QN"] 8.267 μs (5%) 6.58 KiB (1%) 100
["op", "op"] 5.350 μs (5%) 3.56 KiB (1%) 44
["tagset", "tagset"] 208.007 ns (5%) 80 bytes (1%) 1
["tagset", "tagset_unicode"] 359.823 ns (5%) 80 bytes (1%) 1

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["autompo"]
  • ["contract"]
  • ["dmrg"]
  • ["indexset", "constructor"]
  • ["indexset", "filter"]
  • ["indexset", "uniqueinds"]
  • ["inplace"]
  • ["op"]
  • ["tagset"]

Julia versioninfo

Julia Version 1.4.2
Commit 44fa15b150* (2020-05-23 18:35 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.5 LTS
  uname: Linux 5.4.0-1036-azure #38~18.04.1-Ubuntu SMP Wed Jan 6 18:26:30 UTC 2021 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2095 MHz      54464 s          0 s       5206 s      32495 s          0 s
       #2  2095 MHz      48677 s          0 s       7372 s      36373 s          0 s
       
  Memory: 6.791393280029297 GB (2258.6640625 MB free)
  Uptime: 940.0 sec
  Load Avg:  1.22998046875  1.26611328125  0.896484375
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, skylake)

Baseline result

Benchmark Report for /home/runner/work/ITensors.jl/ITensors.jl

Job Properties

  • Time of benchmark: 3 Feb 2021 - 23:30
  • Package commit: 2ec037
  • Julia commit: 44fa15
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["autompo", "Quartic Hamiltonian"] 8.936 s (5%) 605.672 ms 1.78 GiB (1%) 37694072
["autompo", "Quartic QN Hamiltonian"] 18.194 s (5%) 3.297 s 9.67 GiB (1%) 105729131
["contract", "heff_2site"] 6.730 ms (5%) 19.41 MiB (1%) 258
["contract", "matmul_100"] 53.003 μs (5%) 80.44 KiB (1%) 30
["contract", "matmul_20"] 2.738 μs (5%) 5.48 KiB (1%) 29
["contract", "matmul_40"] 8.000 μs (5%) 14.86 KiB (1%) 29
["contract", "matmul_60"] 20.501 μs (5%) 30.44 KiB (1%) 30
["contract", "matmul_80"] 28.401 μs (5%) 52.31 KiB (1%) 30
["contract", "matmul_inplace_100"] 48.602 μs (5%) 1.38 KiB (1%) 18
["contract", "matmul_inplace_20"] 1.460 μs (5%) 1.38 KiB (1%) 18
["contract", "matmul_inplace_40"] 5.560 μs (5%) 1.38 KiB (1%) 18
["contract", "matmul_inplace_60"] 15.500 μs (5%) 1.38 KiB (1%) 18
["contract", "matmul_inplace_80"] 25.001 μs (5%) 1.38 KiB (1%) 18
["dmrg", "1d_S=1_heisenberg"] 25.506 s (5%) 2.617 s 38.55 GiB (1%) 2553806
["dmrg", "1d_S=1_heisenberg_qn"] 13.498 s (5%) 1.887 s 12.36 GiB (1%) 102368146
["indexset", "constructor", "function"] 568.994 ns (5%) 1.97 KiB (1%) 8
["indexset", "filter", "function"] 3.341 s (5%) 851.84 KiB (1%) 16695
["indexset", "filter", "function_order"] 38.270 ns (5%) 224 bytes (1%) 1
["indexset", "filter", "kwargs"] 169.754 ms (5%) 28.75 KiB (1%) 630
["indexset", "filter", "order_kwargs"] 24.374 ns (5%) 112 bytes (1%) 1
["indexset", "uniqueinds", "3_inputs"] 609.056 ns (5%) 864 bytes (1%) 5
["indexset", "uniqueinds", "filter_not_tags"] 662.017 ns (5%) 1.09 KiB (1%) 9
["indexset", "uniqueinds", "filter_tags"] 515.874 ns (5%) 864 bytes (1%) 5
["indexset", "uniqueinds", "nofilter0"] 3.300 μs (5%) 80 bytes (1%) 1
["indexset", "uniqueinds", "nofilter2"] 590.583 ns (5%) 1.17 KiB (1%) 6
["indexset", "uniqueinds", "order0"] 94.961 ns (5%)
["indexset", "uniqueinds", "order2"] 131.791 ns (5%) 224 bytes (1%) 1
["indexset", "uniqueinds", "order_3_inputs"] 215.890 ns (5%) 112 bytes (1%) 1
["indexset", "uniqueinds", "order_filter_not_tags"] 236.953 ns (5%) 368 bytes (1%) 5
["indexset", "uniqueinds", "order_filter_tags"] 83.266 ns (5%) 112 bytes (1%) 1
["inplace", "axpy!"] 12.400 μs (5%) 2.11 KiB (1%) 33
["op", "op QN"] 8.367 μs (5%) 6.58 KiB (1%) 100
["op", "op"] 6.133 μs (5%) 3.56 KiB (1%) 44
["tagset", "tagset"] 204.296 ns (5%) 80 bytes (1%) 1
["tagset", "tagset_unicode"] 356.957 ns (5%) 80 bytes (1%) 1

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["autompo"]
  • ["contract"]
  • ["dmrg"]
  • ["indexset", "constructor"]
  • ["indexset", "filter"]
  • ["indexset", "uniqueinds"]
  • ["inplace"]
  • ["op"]
  • ["tagset"]

Julia versioninfo

Julia Version 1.4.2
Commit 44fa15b150* (2020-05-23 18:35 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 18.04.5 LTS
  uname: Linux 5.4.0-1036-azure #38~18.04.1-Ubuntu SMP Wed Jan 6 18:26:30 UTC 2021 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2095 MHz      91265 s          0 s       8300 s      42226 s          0 s
       #2  2095 MHz      67611 s          0 s       9365 s      65010 s          0 s
       
  Memory: 6.791393280029297 GB (2275.5 MB free)
  Uptime: 1437.0 sec
  Load Avg:  1.06689453125  1.2353515625  1.04931640625
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, skylake)

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() openblas64
Sys.CPU_THREADS 2

lscpu output:

Architecture:        x86_64
CPU op-mode(s):      32-bit, 64-bit
Byte Order:          Little Endian
CPU(s):              2
On-line CPU(s) list: 0,1
Thread(s) per core:  1
Core(s) per socket:  2
Socket(s):           1
NUMA node(s):        1
Vendor ID:           GenuineIntel
CPU family:          6
Model:               85
Model name:          Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
Stepping:            4
CPU MHz:             2095.163
BogoMIPS:            4190.32
Hypervisor vendor:   Microsoft
Virtualization type: full
L1d cache:           32K
L1i cache:           32K
L2 cache:            1024K
L3 cache:            36608K
NUMA node0 CPU(s):   0,1
Flags:               fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear
Cpu Property Value
Brand Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
Vendor :Intel
Architecture :Skylake
Model Family: 0x06, Model: 0x55, Stepping: 0x04, Type: 0x00
Cores 2 physical cores, 2 logical cores (on executing CPU)
No Hyperthreading detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 1024, 36608) kbytes
64 byte cache line size
Address Size 48 bits virtual, 46 bits physical
SIMD 512 bit = 64 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MPO-MPO multiplication for chain length N=1,2 not working
1 participant