Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

212 - show popver in DatasetSelect; allow showing unformatted values in SearchAndSelect #230

Merged
merged 10 commits into from
Sep 19, 2024

Conversation

ri-pandey
Copy link
Contributor

@ri-pandey ri-pandey commented Apr 26, 2024

Description

  • Changed SearchAndSelect to provide formatted as well as raw value to client
  • added popover over dataset's name in DatasetSelect
  • show 20 character's of dataset's name before trimming

Related Issue(s)

Closes #212

Changes Made

List the main changes made in this PR. Be as specific as possible.

  • Feature added
  • Bug fixed
  • Code refactored
  • Documentation updated
  • Other changes: [describe]

Screenshots (if applicable)

Provide screenshots or GIFs that visually represent the changes. If not applicable, you can remove this section.

Screenshot 2024-04-26 at 4 47 08 PM

Checklist

Before submitting this PR, please make sure that:

  • Your code passes linting and coding style checks.
  • Documentation has been updated to reflect the changes.
  • You have reviewed your own code and resolved any merge conflicts.
  • You have requested a review from at least one team member.
  • Any relevant issue(s) have been linked to this PR.

@ri-pandey ri-pandey self-assigned this Apr 26, 2024
@deepakduggirala
Copy link
Contributor

Your changes look good. However, try these things to adjust space allocation to prioritize widening the title column, which holds crucial information in the row, other columns are secondary and can be truncated / hidden.

  • Reducing the width of the checkbox column. There is some white space next to checkboxes.
  • Displaying only the icon of raw data/data product alongside the title in a tooltip, thereby making the type column narrower.

@ri-pandey ri-pandey changed the title 212 - shop popver in DatasetSelect; allow showing unformatted values in SearchAndSelect 212 - show popver in DatasetSelect; allow showing unformatted values in SearchAndSelect Apr 26, 2024
@ri-pandey
Copy link
Contributor Author

@deepakduggirala I have reduced the width of the checkbox column.

Screenshot 2024-05-09 at 11 51 26 AM

Regarding having only the icons of Raw Data/Data Product in the Type column, I don't think that just the icons would provide enough info regarding the type.

I have further increased the number of visible characters in the Name column to 25.

@ri-pandey ri-pandey merged commit 37aee05 into main Sep 19, 2024
@ri-pandey ri-pandey deleted the feature-212 branch September 19, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a way to see full dataset name in DatasetSelect component
2 participants