Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PW_SID:844767] [1/4] util: Remove confusing static keyword use #67

Open
wants to merge 7 commits into
base: workflow
Choose a base branch
from
Open

[PW_SID:844767] [1/4] util: Remove confusing static keyword use #67

wants to merge 7 commits into from

Conversation

IWDTestBot
Copy link
Owner

'__n' is declared as static const which is confusing since it
would imply that __n is only initialized once. This works out in the
end since the macro used in a separate anonymous block, but some compilers
(i.e. clang) will generate a symbol table entry for '__n'. This is not
needed since the expression is always constant.

Declare '__n' as a const size_t instead since that is the type produced
by the sizeof() operation used by L_ARRAY_SIZE.

While here, also declare '__i' as size_t to match '__n'.

Fixes: 4a9f638 ("util: Add L_IN_SET macros")

ell/util.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

jprestwo and others added 7 commits March 28, 2024 23:14
@jprestwo @IWDTestBot
Sync upstream workflow
df2dd33
@jprestwo @IWDTestBot
ci: create PR from patchwork
dca0a15
@jprestwo @IWDTestBot
ci: dispatch IWD CI from ELL
62cb485
@denkenz @IWDTestBot
util: Remove confusing static keyword use
316bdac 
'__n' is declared as static const which is confusing since it
would imply that __n is only initialized once.  This works out in the
end since the macro used in a separate anonymous block, but some compilers
(i.e. clang) will generate a symbol table entry for '__n'.  This is not
needed since the expression is always constant.

Declare '__n' as a const size_t instead since that is the type produced
by the sizeof() operation used by L_ARRAY_SIZE.

While here, also declare '__i' as size_t to match '__n'.

Fixes: 4a9f638 ("util: Add L_IN_SET macros")
@denkenz @IWDTestBot
util: Add L_BIT_{SET|CLEAR|TEST} macros
d01ea1d 
These macros support arbitrarily sized bitmaps using any integer data
type.  It is thus possible to write code like this:

	uint64_t bitmap = 0;
	uint8_t array[4] = {};
	bool r;

	L_BIT_SET(&bitmap, 63);
	r = L_BIT_TEST(&bitmap, 0);

	L_BIT_SET(array, 25);
	r = L_BIT_TEST(array, 31);
@denkenz @IWDTestBot
util: Add L_BITS_{SET|CLEAR}
94f1fdb 
These macros can set or clear an arbitrary number of bits in a single
call, as follows:

	uint64_t bitmap = 0;

	L_BITS_CLEAR(&bitmap, 0, 1, 5, 15, 32, 63);
@denkenz @IWDTestBot
unit: Add tests for the new bitmap utilities
0e82c90
@IWDTestBot
Copy link
Owner Author

Fetch PR
Test ID: fetch
Desc: Fetch the PR commits for this CI run
Duration: 0.00 seconds
Result: PASS

GitLint
Test ID: gitlint
Desc: Run gitlint with rule in .gitlint
Duration: 0.00 seconds
Result: SKIP

Output:

Patchwork not being used, skipping

Make Distcheck
Test ID: makedistcheck
Desc: Run distcheck to check the distribution
Duration: 0.00 seconds
Result: SKIP

Output:

makedistcheck was skipped

Build - Configure
Test ID: build
Desc: Configure the BlueZ source tree
Duration: 0.00 seconds
Result: SKIP

Output:

build was skipped

Make Check
Test ID: makecheck
Desc: Run 'make check'
Duration: 0.00 seconds
Result: SKIP

Output:

makecheck was skipped

Make Check w/Valgrind
Test ID: makecheckvalgrind
Desc: Run 'make check' with Valgrind
Duration: 0.00 seconds
Result: SKIP

Output:

makecheckvalgrind was skipped

Incremental Build with patches
Test ID: incremental_build
Desc: Incremental build per patch in the series
Duration: 0.00 seconds
Result: SKIP

Output:

incremental_build was skipped

Autotest Runner
Test ID: testrunner
Desc: Runs IWD's autotest framework
Duration: 0.00 seconds
Result: SKIP

Output:

testrunner was skipped

Clang Build
Test ID: clang
Desc: Build IWD using clang compiler
Duration: 0.00 seconds
Result: SKIP

Output:

clang was skipped

@IWDTestBot
Copy link
Owner Author

Fetch PR
Test ID: fetch
Desc: Fetch the PR commits for this CI run
Duration: 0.00 seconds
Result: PASS

GitLint
Test ID: gitlint
Desc: Run gitlint with rule in .gitlint
Duration: 0.00 seconds
Result: SKIP

Output:

Patchwork not being used, skipping

Prep - Setup ELL
Test ID: setupell
Desc: Clone, build, and install ELL
Duration: 14.26 seconds
Result: FAIL

Output:

The command rsautl was deprecated in version 3.0. Use 'pkeyutl' instead.
The command rsautl was deprecated in version 3.0. Use 'pkeyutl' instead.
writing RSA key
writing RSA key
writing RSA key
writing RSA key
writing RSA key
In file included from ./ell/ell.h:8,
                 from unit/test-util.c:17:
unit/test-util.c: In function ‘test_set_bit’:
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:379:39: note: in expansion of macro ‘_L_BIT_TO_MASK’
  379 |         _L_BIT_TO_OFFSET(bits, nr) |= _L_BIT_TO_MASK(bits, nr)
      |                                       ^~~~~~~~~~~~~~
unit/test-util.c:203:9: note: in expansion of macro ‘L_BIT_SET’
  203 |         L_BIT_SET(&bitmap[0], 0);
      |         ^~~~~~~~~
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:379:39: note: in expansion of macro ‘_L_BIT_TO_MASK’
  379 |         _L_BIT_TO_OFFSET(bits, nr) |= _L_BIT_TO_MASK(bits, nr)
      |                                       ^~~~~~~~~~~~~~
unit/test-util.c:204:9: note: in expansion of macro ‘L_BIT_SET’
  204 |         L_BIT_SET(bitmap, 1);
      |         ^~~~~~~~~
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:379:39: note: in expansion of macro ‘_L_BIT_TO_MASK’
  379 |         _L_BIT_TO_OFFSET(bits, nr) |= _L_BIT_TO_MASK(bits, nr)
      |                                       ^~~~~~~~~~~~~~
unit/test-util.c:205:9: note: in expansion of macro ‘L_BIT_SET’
  205 |         L_BIT_SET(bitmap, 2);
      |         ^~~~~~~~~
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:379:39: note: in expansion of macro ‘_L_BIT_TO_MASK’
  379 |         _L_BIT_TO_OFFSET(bits, nr) |= _L_BIT_TO_MASK(bits, nr)
      |                                       ^~~~~~~~~~~~~~
unit/test-util.c:206:9: note: in expansion of macro ‘L_BIT_SET’
  206 |         L_BIT_SET(bitmap, 3);
      |         ^~~~~~~~~
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:379:39: note: in expansion of macro ‘_L_BIT_TO_MASK’
  379 |         _L_BIT_TO_OFFSET(bits, nr) |= _L_BIT_TO_MASK(bits, nr)
      |                                       ^~~~~~~~~~~~~~
unit/test-util.c:211:9: note: in expansion of macro ‘L_BIT_SET’
  211 |         L_BIT_SET(bitmap, 63);
      |         ^~~~~~~~~
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:379:39: note: in expansion of macro ‘_L_BIT_TO_MASK’
  379 |         _L_BIT_TO_OFFSET(bits, nr) |= _L_BIT_TO_MASK(bits, nr)
      |                                       ^~~~~~~~~~~~~~
unit/test-util.c:212:9: note: in expansion of macro ‘L_BIT_SET’
  212 |         L_BIT_SET(bitmap, 62);
      |         ^~~~~~~~~
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:379:39: note: in expansion of macro ‘_L_BIT_TO_MASK’
  379 |         _L_BIT_TO_OFFSET(bits, nr) |= _L_BIT_TO_MASK(bits, nr)
      |                                       ^~~~~~~~~~~~~~
unit/test-util.c:213:9: note: in expansion of macro ‘L_BIT_SET’
  213 |         L_BIT_SET(bitmap, 61);
      |         ^~~~~~~~~
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:379:39: note: in expansion of macro ‘_L_BIT_TO_MASK’
  379 |         _L_BIT_TO_OFFSET(bits, nr) |= _L_BIT_TO_MASK(bits, nr)
      |                                       ^~~~~~~~~~~~~~
unit/test-util.c:214:9: note: in expansion of macro ‘L_BIT_SET’
  214 |         L_BIT_SET(bitmap, 60);
      |         ^~~~~~~~~
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:379:39: note: in expansion of macro ‘_L_BIT_TO_MASK’
  379 |         _L_BIT_TO_OFFSET(bits, nr) |= _L_BIT_TO_MASK(bits, nr)
      |                                       ^~~~~~~~~~~~~~
unit/test-util.c:219:9: note: in expansion of macro ‘L_BIT_SET’
  219 |         L_BIT_SET(&one, 0);
      |         ^~~~~~~~~
unit/test-util.c: In function ‘test_clear_bit’:
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:382:40: note: in expansion of macro ‘_L_BIT_TO_MASK’
  382 |         _L_BIT_TO_OFFSET(bits, nr) &= ~_L_BIT_TO_MASK(bits, nr)
      |                                        ^~~~~~~~~~~~~~
unit/test-util.c:227:9: note: in expansion of macro ‘L_BIT_CLEAR’
  227 |         L_BIT_CLEAR(&bitmap[0], 3);
      |         ^~~~~~~~~~~
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:382:40: note: in expansion of macro ‘_L_BIT_TO_MASK’
  382 |         _L_BIT_TO_OFFSET(bits, nr) &= ~_L_BIT_TO_MASK(bits, nr)
      |                                        ^~~~~~~~~~~~~~
unit/test-util.c:228:9: note: in expansion of macro ‘L_BIT_CLEAR’
  228 |         L_BIT_CLEAR(bitmap, 63);
      |         ^~~~~~~~~~~
In file included from unit/test-util.c:12:
unit/test-util.c: In function ‘test_is_bit_set’:
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:385:41: note: in expansion of macro ‘_L_BIT_TO_MASK’
  385 |         ((~_L_BIT_TO_OFFSET(bits, nr) & _L_BIT_TO_MASK(bits, nr)) == 0)
      |                                         ^~~~~~~~~~~~~~
unit/test-util.c:239:16: note: in expansion of macro ‘L_BIT_TEST’
  239 |         assert(L_BIT_TEST(&bitmap[0], 0) == true);
      |                ^~~~~~~~~~
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:385:41: note: in expansion of macro ‘_L_BIT_TO_MASK’
  385 |         ((~_L_BIT_TO_OFFSET(bits, nr) & _L_BIT_TO_MASK(bits, nr)) == 0)
      |                                         ^~~~~~~~~~~~~~
unit/test-util.c:239:16: note: in expansion of macro ‘L_BIT_TEST’
  239 |         assert(L_BIT_TEST(&bitmap[0], 0) == true);
      |                ^~~~~~~~~~
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:385:41: note: in expansion of macro ‘_L_BIT_TO_MASK’
  385 |         ((~_L_BIT_TO_OFFSET(bits, nr) & _L_BIT_TO_MASK(bits, nr)) == 0)
      |                                         ^~~~~~~~~~~~~~
unit/test-util.c:240:16: note: in expansion of macro ‘L_BIT_TEST’
  240 |         assert(L_BIT_TEST(bitmap, 1) == true);
      |                ^~~~~~~~~~
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:385:41: note: in expansion of macro ‘_L_BIT_TO_MASK’
  385 |         ((~_L_BIT_TO_OFFSET(bits, nr) & _L_BIT_TO_MASK(bits, nr)) == 0)
      |                                         ^~~~~~~~~~~~~~
unit/test-util.c:240:16: note: in expansion of macro ‘L_BIT_TEST’
  240 |         assert(L_BIT_TEST(bitmap, 1) == true);
      |                ^~~~~~~~~~
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:385:41: note: in expansion of macro ‘_L_BIT_TO_MASK’
  385 |         ((~_L_BIT_TO_OFFSET(bits, nr) & _L_BIT_TO_MASK(bits, nr)) == 0)
      |                                         ^~~~~~~~~~~~~~
unit/test-util.c:241:16: note: in expansion of macro ‘L_BIT_TEST’
  241 |         assert(L_BIT_TEST(bitmap, 2) == true);
      |                ^~~~~~~~~~
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:385:41: note: in expansion of macro ‘_L_BIT_TO_MASK’
  385 |         ((~_L_BIT_TO_OFFSET(bits, nr) & _L_BIT_TO_MASK(bits, nr)) == 0)
      |                                         ^~~~~~~~~~~~~~
unit/test-util.c:241:16: note: in expansion of macro ‘L_BIT_TEST’
  241 |         assert(L_BIT_TEST(bitmap, 2) == true);
      |                ^~~~~~~~~~
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:385:41: note: in expansion of macro ‘_L_BIT_TO_MASK’
  385 |         ((~_L_BIT_TO_OFFSET(bits, nr) & _L_BIT_TO_MASK(bits, nr)) == 0)
      |                                         ^~~~~~~~~~~~~~
unit/test-util.c:242:16: note: in expansion of macro ‘L_BIT_TEST’
  242 |         assert(L_BIT_TEST(bitmap, 3) == true);
      |                ^~~~~~~~~~
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:385:41: note: in expansion of macro ‘_L_BIT_TO_MASK’
  385 |         ((~_L_BIT_TO_OFFSET(bits, nr) & _L_BIT_TO_MASK(bits, nr)) == 0)
      |                                         ^~~~~~~~~~~~~~
unit/test-util.c:242:16: note: in expansion of macro ‘L_BIT_TEST’
  242 |         assert(L_BIT_TEST(bitmap, 3) == true);
      |                ^~~~~~~~~~
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:385:41: note: in expansion of macro ‘_L_BIT_TO_MASK’
  385 |         ((~_L_BIT_TO_OFFSET(bits, nr) & _L_BIT_TO_MASK(bits, nr)) == 0)
      |                                         ^~~~~~~~~~~~~~
unit/test-util.c:243:16: note: in expansion of macro ‘L_BIT_TEST’
  243 |         assert(L_BIT_TEST(bitmap, 4) == false);
      |                ^~~~~~~~~~
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:385:41: note: in expansion of macro ‘_L_BIT_TO_MASK’
  385 |         ((~_L_BIT_TO_OFFSET(bits, nr) & _L_BIT_TO_MASK(bits, nr)) == 0)
      |                                         ^~~~~~~~~~~~~~
unit/test-util.c:243:16: note: in expansion of macro ‘L_BIT_TEST’
  243 |         assert(L_BIT_TEST(bitmap, 4) == false);
      |                ^~~~~~~~~~
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:385:41: note: in expansion of macro ‘_L_BIT_TO_MASK’
  385 |         ((~_L_BIT_TO_OFFSET(bits, nr) & _L_BIT_TO_MASK(bits, nr)) == 0)
      |                                         ^~~~~~~~~~~~~~
unit/test-util.c:245:16: note: in expansion of macro ‘L_BIT_TEST’
  245 |         assert(L_BIT_TEST(bitmap, 63) == true);
      |                ^~~~~~~~~~
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:385:41: note: in expansion of macro ‘_L_BIT_TO_MASK’
  385 |         ((~_L_BIT_TO_OFFSET(bits, nr) & _L_BIT_TO_MASK(bits, nr)) == 0)
      |                                         ^~~~~~~~~~~~~~
unit/test-util.c:245:16: note: in expansion of macro ‘L_BIT_TEST’
  245 |         assert(L_BIT_TEST(bitmap, 63) == true);
      |                ^~~~~~~~~~
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:385:41: note: in expansion of macro ‘_L_BIT_TO_MASK’
  385 |         ((~_L_BIT_TO_OFFSET(bits, nr) & _L_BIT_TO_MASK(bits, nr)) == 0)
      |                                         ^~~~~~~~~~~~~~
unit/test-util.c:246:16: note: in expansion of macro ‘L_BIT_TEST’
  246 |         assert(L_BIT_TEST(bitmap, 55) == false);
      |                ^~~~~~~~~~
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:385:41: note: in expansion of macro ‘_L_BIT_TO_MASK’
  385 |         ((~_L_BIT_TO_OFFSET(bits, nr) & _L_BIT_TO_MASK(bits, nr)) == 0)
      |                                         ^~~~~~~~~~~~~~
unit/test-util.c:246:16: note: in expansion of macro ‘L_BIT_TEST’
  246 |         assert(L_BIT_TEST(bitmap, 55) == false);
      |                ^~~~~~~~~~
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:385:41: note: in expansion of macro ‘_L_BIT_TO_MASK’
  385 |         ((~_L_BIT_TO_OFFSET(bits, nr) & _L_BIT_TO_MASK(bits, nr)) == 0)
      |                                         ^~~~~~~~~~~~~~
unit/test-util.c:248:16: note: in expansion of macro ‘L_BIT_TEST’
  248 |         assert(L_BIT_TEST(&one, 0) == true);
      |                ^~~~~~~~~~
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:385:41: note: in expansion of macro ‘_L_BIT_TO_MASK’
  385 |         ((~_L_BIT_TO_OFFSET(bits, nr) & _L_BIT_TO_MASK(bits, nr)) == 0)
      |                                         ^~~~~~~~~~~~~~
unit/test-util.c:248:16: note: in expansion of macro ‘L_BIT_TEST’
  248 |         assert(L_BIT_TEST(&one, 0) == true);
      |                ^~~~~~~~~~
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:385:41: note: in expansion of macro ‘_L_BIT_TO_MASK’
  385 |         ((~_L_BIT_TO_OFFSET(bits, nr) & _L_BIT_TO_MASK(bits, nr)) == 0)
      |                                         ^~~~~~~~~~~~~~
unit/test-util.c:249:16: note: in expansion of macro ‘L_BIT_TEST’
  249 |         assert(L_BIT_TEST(&one, 1) == false);
      |                ^~~~~~~~~~
./ell/util.h:371:31: error: variable ‘mask’ set but not used [-Werror=unused-but-set-variable]
  371 |         const typeof(*(bits)) mask = (typeof(*(bits)))1 << shift;       \
      |                               ^~~~
./ell/util.h:385:41: note: in expansion of macro ‘_L_BIT_TO_MASK’
  385 |         ((~_L_BIT_TO_OFFSET(bits, nr) & _L_BIT_TO_MASK(bits, nr)) == 0)
      |                                         ^~~~~~~~~~~~~~
unit/test-util.c:249:16: note: in expansion of macro ‘L_BIT_TEST’
  249 |         assert(L_BIT_TEST(&one, 1) == false);
      |                ^~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:2009: unit/test-util.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1295: all] Error 2

Make Distcheck
Test ID: makedistcheck
Desc: Run distcheck to check the distribution
Duration: 0.00 seconds
Result: SKIP

Output:

makedistcheck was skipped

Build - Configure
Test ID: build
Desc: Configure the BlueZ source tree
Duration: 0.00 seconds
Result: SKIP

Output:

build was skipped

Make Check
Test ID: makecheck
Desc: Run 'make check'
Duration: 0.00 seconds
Result: SKIP

Output:

makecheck was skipped

Make Check w/Valgrind
Test ID: makecheckvalgrind
Desc: Run 'make check' with Valgrind
Duration: 0.00 seconds
Result: SKIP

Output:

makecheckvalgrind was skipped

Incremental Build with patches
Test ID: incremental_build
Desc: Incremental build per patch in the series
Duration: 0.00 seconds
Result: SKIP

Output:

incremental_build was skipped

Autotest Runner
Test ID: testrunner
Desc: Runs IWD's autotest framework
Duration: 0.00 seconds
Result: SKIP

Output:

testrunner was skipped

Clang Build
Test ID: clang
Desc: Build IWD using clang compiler
Duration: 0.00 seconds
Result: SKIP

Output:

clang was skipped

@github-actions github-actions bot force-pushed the workflow branch 4 times, most recently from 70750ab to 108b545 Compare June 3, 2024 18:40
@github-actions github-actions bot force-pushed the workflow branch 2 times, most recently from cf9aae3 to d96cbc5 Compare June 20, 2024 15:17
@github-actions github-actions bot force-pushed the workflow branch 3 times, most recently from ae6045c to a70fe95 Compare July 30, 2024 19:13
@github-actions github-actions bot force-pushed the workflow branch 2 times, most recently from b70a423 to f7b1d76 Compare August 28, 2024 15:37
@github-actions github-actions bot force-pushed the workflow branch 2 times, most recently from 3164ee9 to 1f782ea Compare September 9, 2024 06:46
@github-actions github-actions bot force-pushed the workflow branch 2 times, most recently from c181123 to 8f71769 Compare November 7, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IWDTestBot @jprestwo @denkenz